Skip to content

chore: tweak template generation logic #13283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2024
Merged

chore: tweak template generation logic #13283

merged 3 commits into from
Sep 17, 2024

Conversation

Rich-Harris
Copy link
Member

#13075 added support for expressions in templates, but I think we can neaten it up a bit — rather than creating new push_quasi and push_expression functions, state.template can just be an Array<string | Expression> that gets processed later. This is more efficient, and in line with how similar problems are solved elsewhere in the codebase. (In terms of variable naming: it's awkward to have an array with a singular name — quasi — which then forces the individual quasi to be called something cumbersome like quasi_to_add. It should just be quasis.push(quasi)! Though really it should have been strings.push(string), because we're not actually dealing with quasis at this point.)

Another benefit of this approach is that we can vary the output more easily — we could, if we chose, emit "a" + b + "c" instead of `a${b}c` more easily than if we're constructing the expression on the fly.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Sep 17, 2024

⚠️ No Changeset found

Latest commit: f107c76

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely more consistent with other parts of the codebase.

@Rich-Harris Rich-Harris merged commit a88e2dc into main Sep 17, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the tweak-template-logic branch September 17, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants