-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
chore: transformers #12780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
chore: transformers #12780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #12744 — a prerequisite for #12742 — it became clear that overhauling the way we transform state bindings couldn't wait any longer. The current code really is baffling — convoluted thickets of
if
statements, and logic scattered all over the place.This PR introduces a completely new approach, expanding on #12530 and #12697. It adds the concept of ad hoc transformation functions to client transform state, where a transform is an object with a
read
method and (optionally)assign
,mutate
andupdate
methods.In other words we can declare all the logic for (for example) props or legacy reactive imports in one place, rather than having the setup logic over here, the getter logic over there, and the setter logic over in some other place. Distinguishing reassignments and mutations also makes everything much cleaner. (Updates fall back to assignments if no
update
function is provided.)Draft because it's not quite finished:
Before submitting the PR, please make sure you do the following
feat:
,fix:
,chore:
, ordocs:
.Tests and linting
pnpm test
and lint the project withpnpm lint