breaking: avoid flushing queued updates on mount/hydrate #12587
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2901e6e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Rich-Harris
reviewed
Jul 24, 2024
|
With this change, is there still a difference between |
Co-authored-by: Rich Harris <[email protected]>
Doesn't it have some usage still for avoiding the microtask being created? In any case, we can defer that to an issue or another PR. I don't think it needs to be attached to this change. |
Rich-Harris
approved these changes
Jul 24, 2024
Rich-Harris
added a commit
that referenced
this pull request
Jul 24, 2024
)" This reverts commit 20b8797.
Rich-Harris
added a commit
that referenced
this pull request
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a hunch that this might fix #12477.
Ultimately though,
mountandhydrateshouldn't be considered synchronous. It prevents us from doing asynchronous things in the future, plus it slightly negatively impacts performance.