Skip to content

fix: tweak element_invalid_self_closing_tag to exclude namespace #12585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

trueadm
Copy link
Contributor

@trueadm trueadm commented Jul 24, 2024

Fixes #12546

Copy link

changeset-bot bot commented Jul 24, 2024

🦋 Changeset detected

Latest commit: 945f61e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

The alternative would be to just bail on elements containing : - I'm not sure which is better, but this version surely fixes the referenced issue

@Rich-Harris
Copy link
Member

This version is better — we wouldn't want to allow <enhanced:div /> for example. If we make the assumption that these namespacey mechanisms are generally going to be ways to enhance built-in elements, this feels like the right fix

@Rich-Harris Rich-Harris merged commit abaa441 into main Jul 24, 2024
9 checks passed
@Rich-Harris Rich-Harris deleted the revise-self-closing-tag-warning branch July 24, 2024 18:35
This was referenced Jul 24, 2024
ryoppippi added a commit to vim-jp-radio/LP that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

element_invalid_self_closing_tag triggers on <enhanced:img />
3 participants