Skip to content

[WIP] fix some TODOs #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 8, 2018
Merged

[WIP] fix some TODOs #1193

merged 6 commits into from
Mar 8, 2018

Conversation

Rich-Harris
Copy link
Member

Lots of TODO comments in the codebase — some of them are probably fairly easy to fix

@codecov-io
Copy link

codecov-io commented Feb 25, 2018

Codecov Report

Merging #1193 into master will increase coverage by <.01%.
The diff coverage is 90.9%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1193      +/-   ##
==========================================
+ Coverage   91.69%   91.69%   +<.01%     
==========================================
  Files         127      126       -1     
  Lines        4564     4566       +2     
  Branches     1505     1495      -10     
==========================================
+ Hits         4185     4187       +2     
- Misses        157      158       +1     
+ Partials      222      221       -1
Impacted Files Coverage Δ
src/generators/dom/index.ts 96.21% <ø> (ø) ⬆️
src/generators/Generator.ts 94.01% <ø> (-0.1%) ⬇️
src/generators/dom/Block.ts 96.82% <ø> (ø) ⬆️
src/validate/js/utils/usesThisOrArguments.ts 81.81% <ø> (ø) ⬆️
src/validate/html/index.ts 97.87% <100%> (+0.04%) ⬆️
src/parse/state/tag.ts 96.4% <100%> (+0.04%) ⬆️
src/generators/nodes/Slot.ts 91.04% <100%> (+0.88%) ⬆️
src/generators/nodes/MustacheTag.ts 91.66% <50%> (-8.34%) ⬇️
src/generators/nodes/RawMustacheTag.ts 97.67% <50%> (-2.33%) ⬇️
src/generators/nodes/Text.ts 95.23% <50%> (-4.77%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22f0ed9...0c66e9e. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 0c3e44a into master Mar 8, 2018
@Rich-Harris Rich-Harris deleted the TODO branch March 8, 2018 01:55
7nik pushed a commit to 7nik/svelte that referenced this pull request Apr 9, 2025
sync kit docs

Co-authored-by: svelte-docs-bot[bot] <196124396+svelte-docs-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants