Skip to content

Use classes for style encapsulation, rather than attributes #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 8, 2018

Conversation

Rich-Harris
Copy link
Member

Fixes #1118

@codecov-io
Copy link

codecov-io commented Feb 24, 2018

Codecov Report

Merging #1190 into master will decrease coverage by 0.02%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1190      +/-   ##
==========================================
- Coverage   91.69%   91.67%   -0.03%     
==========================================
  Files         126      126              
  Lines        4566     4575       +9     
  Branches     1495     1501       +6     
==========================================
+ Hits         4187     4194       +7     
  Misses        158      158              
- Partials      221      223       +2
Impacted Files Coverage Δ
src/generators/dom/index.ts 96.17% <ø> (-0.05%) ⬇️
src/css/Stylesheet.ts 91.2% <100%> (ø) ⬆️
...nerators/server-side-rendering/visitors/Element.ts 92.1% <100%> (+0.67%) ⬆️
src/utils/hash.ts 100% <100%> (ø) ⬆️
src/generators/nodes/Element.ts 94.6% <85.71%> (-0.29%) ⬇️
src/generators/nodes/Attribute.ts 85.64% <86.66%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c3e44a...7d4958b. Read the comment docs.

@Rich-Harris Rich-Harris merged commit 46c9ad4 into master Mar 8, 2018
@Rich-Harris Rich-Harris deleted the gh-1118 branch March 8, 2018 02:47
7nik pushed a commit to 7nik/svelte that referenced this pull request Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants