Skip to content

fix: $state.is missing second argument on the server #11835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2024
Merged

fix: $state.is missing second argument on the server #11835

merged 2 commits into from
May 29, 2024

Conversation

paoloricciuti
Copy link
Member

Svelte 5 rewrite

Closes #11829

On the server the transform was missing the second argument so the generated code was from $state.is(a, b) to Object.is(a) resulting in always false.

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented May 29, 2024

🦋 Changeset detected

Latest commit: dbd17fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry
Copy link
Member

I believe we have some other tests that are specifically testing SSR-only behavior without hydration. We should be able to do something that makes assertions about the behavior of the component rather than testing for specific compiler output - which is brittle, and makes it difficult to see what behavior is actually being tested for. Snapshot testing should be reserved for when there really isn't another good way to test what we're looking for via the component's externally visible behavior.

@paoloricciuti
Copy link
Member Author

I believe we have some other tests that are specifically testing SSR-only behavior without hydration. We should be able to do something that makes assertions about the behavior of the component rather than testing for specific compiler output - which is brittle, and makes it difficult to see what behavior is actually being tested for. Snapshot testing should be reserved for when there really isn't another good way to test what we're looking for via the component's externally visible behavior.

Uhm yeah i guess i can just test the result of object.is SSRd...i tought that since this was specifically about the code output was better to test through snapshot. Fixing now.

@trueadm trueadm merged commit 82a645f into sveltejs:main May 29, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$state.is always returns false during ssr
3 participants