Skip to content

fix: only destroy snippets when they have changed #11267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 22, 2024
Merged

fix: only destroy snippets when they have changed #11267

merged 5 commits into from
Apr 22, 2024

Conversation

Rich-Harris
Copy link
Member

Fixes #11266. For the life of me I can't reproduce the bug in our test suite — I've been tearing my hair out for a while, and can't afford to waste any more time on it — and as such there's no test with this PR.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Apr 20, 2024

🦋 Changeset detected

Latest commit: 3366776

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

Is it a dev only bug maybe? In that case, maybe compilerOptions: { dev: true } helps

@Rich-Harris
Copy link
Member Author

I had the same thought but it made no difference and I gave up

@dummdidumm
Copy link
Member

compilerOptions: { accessors: false } (because IIRC they're enabled by default in the test suite)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Svelte 5 Bug - spreading value and oninput props make snippet disappear on input change
2 participants