Skip to content

chore: refactor $inspect #11226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 18, 2024
Merged

chore: refactor $inspect #11226

merged 3 commits into from
Apr 18, 2024

Conversation

Rich-Harris
Copy link
Member

This is a precursor to a more useful $inspect rune (or more accurately, a more useful $state.snapshot rune). It's mostly just moving some code around (making runtime.js less hilariously overstuffed), but also provides a better error when $inspect is used in the wrong place. (Side-note: the error we print when using $effect or $effect.pre outside an effect is wrong — it says you can only use them during component initialisation which is obviously untrue. Will open a PR to fix.)

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Apr 18, 2024

⚠️ No Changeset found

Latest commit: a61c5f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member Author

self-merging to unblock other work

@Rich-Harris Rich-Harris merged commit 307f15d into main Apr 18, 2024
8 checks passed
@Rich-Harris Rich-Harris deleted the refactor-inspect branch April 18, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant