Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another piece of #10594. While working on that PR I found it made a huge difference to update the various signal types:
interface
instead oftype
(interface
is less forgiving)SourceSignal
toSource
, etcDerived
extendSource
, rather than deriveds sharing a type with effects, since they have much more in common with each otherValue
type which is a union ofSource
andDerived
, and aReaction
type which is a union ofDerived
andEffect
Signal
type (which is a union of all three) unless necessaryThere's more to do still (renaming some variables, replacing the one character
signal.x
style properties with something a bit less cryptic, getting rid of unusedDerived
properties) but that can happen in follow-up PRs.