Skip to content

chore: refactor rendering and transitions #10594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 111 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
111 commits
Select commit Hold shift + click to select a range
a8333d5
move effect code
Rich-Harris Feb 20, 2024
c7895db
move source code
Rich-Harris Feb 20, 2024
34dbee7
derived
Rich-Harris Feb 20, 2024
d95b6e7
move more stuff
Rich-Harris Feb 20, 2024
de366a8
simplify
Rich-Harris Feb 21, 2024
b3a5720
init is a daft name for something that runs repeatedly
Rich-Harris Feb 21, 2024
cf59065
remove unneeded effect variant
Rich-Harris Feb 21, 2024
2c19603
blockless if block
Rich-Harris Feb 21, 2024
ca7aa3c
merge main
Rich-Harris Feb 21, 2024
83f194d
oops
Rich-Harris Feb 21, 2024
7884528
oops
Rich-Harris Feb 21, 2024
5977ba9
unused
Rich-Harris Feb 21, 2024
30aa566
progress
Rich-Harris Feb 21, 2024
032b739
WIP transitions
Rich-Harris Feb 21, 2024
c2df07f
reversing
Rich-Harris Feb 21, 2024
044c1a1
various
Rich-Harris Feb 21, 2024
32202bd
simplify
Rich-Harris Feb 21, 2024
66f2e95
remove unused code
Rich-Harris Feb 21, 2024
75d7ca8
always bind effects to parents
Rich-Harris Feb 21, 2024
b73c077
WIP each blocks
Rich-Harris Feb 21, 2024
7503afd
unused
Rich-Harris Feb 21, 2024
0085226
unused
Rich-Harris Feb 21, 2024
0f9256e
simplify
Rich-Harris Feb 21, 2024
4e3ddd8
each hydration
Rich-Harris Feb 22, 2024
3963ff9
fix $effect.root
Rich-Harris Feb 22, 2024
e474ffe
type stuff
Rich-Harris Feb 22, 2024
f9eae70
keyed each partly working
Rich-Harris Feb 22, 2024
0401bb3
note to self
Rich-Harris Feb 22, 2024
39a17d2
Merge branch 'main' into blockless
Rich-Harris Feb 22, 2024
0545dbf
some type stuff
Rich-Harris Feb 22, 2024
34f3198
type stuff
Rich-Harris Feb 22, 2024
26e9c8c
remove some unused code
Rich-Harris Feb 22, 2024
7190f99
fix some stuff
Rich-Harris Feb 22, 2024
9f7c632
missed a spot
Rich-Harris Feb 22, 2024
cffc51d
fixes
Rich-Harris Feb 22, 2024
f7b194f
await blocks
Rich-Harris Feb 22, 2024
4abd99f
fix some stuff
Rich-Harris Feb 22, 2024
6785a53
damn this feels good
Rich-Harris Feb 22, 2024
61f62cc
remove some stuff
Rich-Harris Feb 22, 2024
f073e22
remove more stuff
Rich-Harris Feb 22, 2024
3169490
more
Rich-Harris Feb 22, 2024
15b47d2
oops
Rich-Harris Feb 22, 2024
16a6b68
fix
Rich-Harris Feb 23, 2024
3e8f703
partial fix
Rich-Harris Feb 23, 2024
8537c5c
note to self
Rich-Harris Feb 23, 2024
68ee332
clear raf tasks after test
Rich-Harris Feb 23, 2024
582c4d1
teardown on pause
Rich-Harris Feb 23, 2024
35bec17
TS
Rich-Harris Feb 23, 2024
3be1b21
delay
Rich-Harris Feb 23, 2024
dc424a0
local transitions
Rich-Harris Feb 23, 2024
1888587
set component context
Rich-Harris Feb 23, 2024
7b9fb60
reimplement <svelte:element>
Rich-Harris Feb 23, 2024
529f987
move <svelte:component> code
Rich-Harris Feb 23, 2024
ba0eed1
simplify autofocus
Rich-Harris Feb 23, 2024
9db4810
tweak
Rich-Harris Feb 23, 2024
375575c
move render code
Rich-Harris Feb 23, 2024
7d9808c
remove some unused stuff
Rich-Harris Feb 23, 2024
88d8813
remove some block-related code
Rich-Harris Feb 23, 2024
577b8b6
random-ass code
Rich-Harris Feb 23, 2024
cd58dbd
remove stuff
Rich-Harris Feb 23, 2024
c80fe45
delete some unused stuff
Rich-Harris Feb 23, 2024
db2ffd7
typo
Rich-Harris Feb 23, 2024
a8bbc8b
remove unused arg
Rich-Harris Feb 23, 2024
4052310
just comment this out until we can make sense of it
Rich-Harris Feb 23, 2024
c431330
remove more stuff
Rich-Harris Feb 23, 2024
94a7a32
html tags
Rich-Harris Feb 23, 2024
ba6f24b
move css props
Rich-Harris Feb 23, 2024
c28534e
simplify
Rich-Harris Feb 23, 2024
25dcfab
rename types
Rich-Harris Feb 23, 2024
611346e
remove unused type
Rich-Harris Feb 23, 2024
4e9cf14
Merge branch 'main' into blockless
Rich-Harris Feb 23, 2024
6be359b
start moving signal types over
Rich-Harris Feb 24, 2024
987d5e9
more
Rich-Harris Feb 24, 2024
c6a2e54
tidy up types a bit
Rich-Harris Feb 24, 2024
b81a1fb
tidy up types a bit
Rich-Harris Feb 24, 2024
393c2d5
reduce indirection
Rich-Harris Feb 24, 2024
752c42a
move some code
Rich-Harris Feb 24, 2024
e064363
more tidying up
Rich-Harris Feb 24, 2024
05c55dd
tidy up
Rich-Harris Feb 24, 2024
b38669a
not exported
Rich-Harris Feb 24, 2024
312322f
remove unused code
Rich-Harris Feb 24, 2024
274c7c2
tidy up
Rich-Harris Feb 24, 2024
530fd65
tidy up
Rich-Harris Feb 24, 2024
d109adc
simplify
Rich-Harris Feb 24, 2024
1d89260
tidy up
Rich-Harris Feb 24, 2024
8f4dc6b
tidy up
Rich-Harris Feb 24, 2024
4abc436
tidy up
Rich-Harris Feb 24, 2024
8d383ae
tidy up
Rich-Harris Feb 24, 2024
20b7b54
tidy up
Rich-Harris Feb 24, 2024
e6b8022
move set
Rich-Harris Feb 24, 2024
6b664a7
tidy up
Rich-Harris Feb 24, 2024
ba23231
tidy up
Rich-Harris Feb 24, 2024
a57168a
more consistent naming
Rich-Harris Feb 24, 2024
241622d
unused
Rich-Harris Feb 24, 2024
3682c3e
more
Rich-Harris Feb 24, 2024
e106bbc
reduce indirection
Rich-Harris Feb 24, 2024
bcd8bf3
tidy up
Rich-Harris Feb 26, 2024
9734f62
partial fix
Rich-Harris Feb 26, 2024
5ae93db
Merge branch 'main' into blockless
Rich-Harris Feb 26, 2024
c192259
fix <svelte:element>
Rich-Harris Feb 26, 2024
39c16c9
partial fix
Rich-Harris Feb 26, 2024
f38006a
Merge branch 'main' into blockless
dummdidumm Feb 29, 2024
32b79ce
merge main
Rich-Harris Mar 2, 2024
adb8118
Merge branch 'main' into blockless
Rich-Harris Mar 4, 2024
33bd68b
merge main
Rich-Harris Mar 4, 2024
850dcbe
merge main
Rich-Harris Mar 5, 2024
0b6f629
merge main
Rich-Harris Mar 5, 2024
38f5911
merge main
Rich-Harris Mar 5, 2024
a1d70db
merge main
Rich-Harris Mar 7, 2024
5231ae4
merge main
Rich-Harris Mar 10, 2024
ca6ba9b
Merge branch 'main' into blockless
Rich-Harris Mar 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 0 additions & 93 deletions packages/svelte/src/internal/client/block.js

This file was deleted.

14 changes: 2 additions & 12 deletions packages/svelte/src/internal/client/constants.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
export const SOURCE = 1;
export const DERIVED = 1 << 1;
export const EFFECT = 1 << 2;
export const PRE_EFFECT = 1 << 3;
Expand All @@ -10,17 +9,8 @@ export const DIRTY = 1 << 9;
export const MAYBE_DIRTY = 1 << 10;
export const INERT = 1 << 11;
export const DESTROYED = 1 << 12;

export const ROOT_BLOCK = 0;
export const IF_BLOCK = 1;
export const EACH_BLOCK = 2;
export const EACH_ITEM_BLOCK = 3;
export const AWAIT_BLOCK = 4;
export const KEY_BLOCK = 5;
export const HEAD_BLOCK = 6;
export const DYNAMIC_COMPONENT_BLOCK = 7;
export const DYNAMIC_ELEMENT_BLOCK = 8;
export const SNIPPET_BLOCK = 9;
export const ROOT_EFFECT = 1 << 13;
export const BRANCH_EFFECT = 1 << 14;

export const UNINITIALIZED = Symbol();
export const STATE_SYMBOL = Symbol('$state');
Loading