feat: add hydrate method, make hydration treeshakeable #10497
Conversation
🦋 Changeset detectedLatest commit: c2dfc0c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: Ben McCann <[email protected]>
…into treeshakeable-hydration
| /** @type {Node} */ | ||
| let target_node = anchor_node; | ||
| if (current_hydration_fragment !== null) { | ||
| if (hydrating) { |
There was a problem hiding this comment.
do we need this (and similar) guards? surely we're already only calling functions like hydrate_block_anchor when we're hydrating. rollup is smart enough to deal with it
There was a problem hiding this comment.
Depends on the method, in this case there's no if block at the call site because it would result in more if block code overall.
There was a problem hiding this comment.
This is what I was talking about last week in our call. I wasn't seeing the tree shaking working as expected by Rollup. However, if you put into this boolean guard then it works great – something I didn't do.
sites/svelte-5-preview/src/routes/docs/content/01-api/05-functions.md
Outdated
Show resolved
Hide resolved
Introduces a new
hydratemethod which does hydration. Refactors code so that hydration-related code is treeshaken out when not using that method.closes #9533
part of #9827
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.Tests and linting
pnpm testand lint the project withpnpm lint