Skip to content

feat: add fetchpriority to img attrs #10388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 4, 2024

Conversation

ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Feb 4, 2024

This PR adds the fetchpriority attribute to HTML attributes. This has been requested in #8099, which was rejected as an experimental feature. It is now implemented in Chromium and Safari, and is in the WhatWG spec.

I am the maintainer of @unpic/svelte (recommended in the docs ), and currently need to add it as an augmented property. It would be good if we could add it instead.

Fixes #8099

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Copy link

changeset-bot bot commented Feb 4, 2024

⚠️ No Changeset found

Latest commit: aaa3420

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah makes sense to add it now 👍
This is the Svelte 5 branch, can you open a similar one for the svelte-4 branch?

@ascorbic
Copy link
Contributor Author

ascorbic commented Feb 4, 2024

@dummdidumm done in #10390!

@ascorbic ascorbic requested a review from dummdidumm February 4, 2024 15:32
@dummdidumm dummdidumm merged commit d23805a into sveltejs:main Feb 4, 2024
@ascorbic ascorbic deleted the mk/fetchpriority branch February 4, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing fetchpriority property to img on html element
2 participants