Svelte 5: bind:group incorrectly considers other groups when changing value #9947
Comments
1 task
|
Any news on this? It's basically what stops Superforms from working in Svelte 5, so it would be great it it was fixed. |
This was referenced Jan 30, 2024
dummdidumm
added a commit
that referenced
this issue
Feb 1, 2024
- Previously, any each block parents where used as keys for the sub group. That's wrong, it should only be using each blocks whos declarations contribute to the `bind:group` expression. Fixes #10345 - Only the left-most identifier of the expression was used to determine the binding group. This is wrong, all identifiers within the expression need to be taken into account. Fixes #9947
5 tasks
dummdidumm
added a commit
that referenced
this issue
Feb 1, 2024
- Previously, any each block parents where used as keys for the sub group. That's wrong, it should only be using each blocks whos declarations contribute to the `bind:group` expression. Fixes #10345 - Only the left-most identifier of the expression was used to determine the binding group. This is wrong, all identifiers within the expression need to be taken into account. Fixes #9947
4 tasks
5 tasks
dummdidumm
added a commit
that referenced
this issue
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When using
bind:groupon a store with nested data, previous groups are taken into account, returning an incorrect value when updating the store. This worked fine in Svelte 4.I tracked the error to the functions
bind_groupandget_binding_group_valuein render.js, where it seems like all groups are concatenated into one, which will be used in the latter function.Reproduction
Svelte 5 preview site
Logs
No response
System Info
Severity
blocking an upgrade
The text was updated successfully, but these errors were encountered: