Skip to content

Cannot set volume without binding #12029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ottomated opened this issue Jun 13, 2024 · 0 comments · Fixed by #12485
Closed

Cannot set volume without binding #12029

ottomated opened this issue Jun 13, 2024 · 0 comments · Fixed by #12485

Comments

@ottomated
Copy link
Contributor

Describe the bug

To set the volume of an audio or video element, you must bind to it. <audio bind:volume> works, but <audio volume={volume}> fails silently.

This does match the HTML spec, but the problem is that the IDE will suggest it as a property that can be set:
image

To solve this, either the type should be updated to remove the property without binding, or setting volume without binding should be supported.

Reproduction

REPL

Logs

No response

System Info

System:
    OS: macOS 14.5
    CPU: (8) arm64 Apple M2
    Memory: 75.02 MB / 16.00 GB
    Shell: 3.6.1 - /opt/homebrew/bin/fish
  Binaries:
    Node: 20.11.0 - ~/.volta/tools/image/node/20.11.0/bin/node
    Yarn: 4.0.0-rc.53 - ~/.volta/tools/image/yarn/4.0.0-rc.53/bin/yarn
    npm: 10.2.4 - ~/.volta/tools/image/node/20.11.0/bin/npm
    pnpm: 9.0.6 - ~/.volta/bin/pnpm
    bun: 1.1.12 - ~/.bun/bin/bun
  Browsers:
    Chrome: 125.0.6422.142
    Safari: 17.5

Severity

annoyance

dummdidumm added a commit that referenced this issue Jul 17, 2024
Already works when using spread attributes, but not when setting it on its own
fixes #12029
Rich-Harris pushed a commit that referenced this issue Jul 18, 2024
Already works when using spread attributes, but not when setting it on its own
fixes #12029
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant