enhance error message

dummdidumm · dummdidumm · commit 8f44b5833270 · 2024-09-03T10:57:10.000+02:00
diff --git a/packages/svelte/messages/compile-errors/script.md b/packages/svelte/messages/compile-errors/script.md
@@ -162,4 +162,4 @@ Using a `$` prefix to refer to the value of a store is only possible inside `.sv
 
 ## typescript_invalid_feature
 
-> TypeScript language features like %feature% are not natively supported, and their use is generally discouraged. You will need to use a preprocessor to convert it to JavaScript before it gets passed to the Svelte compiler
+> TypeScript language features like %feature% are not natively supported, and their use is generally discouraged. Outside of `<script>` tags, these features are not supported. For use within `<script>` tags, you will need to use a preprocessor to convert it to JavaScript before it gets passed to the Svelte compiler. If you are using `vitePreprocess`, make sure to specifically enable preprocessing script tags (`vitePreprocess({ script: true })`)
diff --git a/packages/svelte/src/compiler/errors.js b/packages/svelte/src/compiler/errors.js
@@ -435,13 +435,13 @@ export function store_invalid_subscription_module(node) {
 }
 
 /**
- * TypeScript language features like %feature% are not natively supported, and their use is generally discouraged. You will need to use a preprocessor to convert it to JavaScript before it gets passed to the Svelte compiler
+ * TypeScript language features like %feature% are not natively supported, and their use is generally discouraged. Outside of `<script>` tags, these features are not supported. For use within `<script>` tags, you will need to use a preprocessor to convert it to JavaScript before it gets passed to the Svelte compiler. If you are using `vitePreprocess`, make sure to specifically enable preprocessing script tags (`vitePreprocess({ script: true })`)
  * @param {null | number | NodeLike} node
  * @param {string} feature
  * @returns {never}
  */
 export function typescript_invalid_feature(node, feature) {
-	e(node, "typescript_invalid_feature", `TypeScript language features like ${feature} are not natively supported, and their use is generally discouraged. You will need to use a preprocessor to convert it to JavaScript before it gets passed to the Svelte compiler`);
+	e(node, "typescript_invalid_feature", `TypeScript language features like ${feature} are not natively supported, and their use is generally discouraged. Outside of \`<script>\` tags, these features are not supported. For use within \`<script>\` tags, you will need to use a preprocessor to convert it to JavaScript before it gets passed to the Svelte compiler. If you are using \`vitePreprocess\`, make sure to specifically enable preprocessing script tags (\`vitePreprocess({ script: true })\`)`);
 }
 
 /**
diff --git a/packages/svelte/tests/validator/samples/ts-unsupported-accessor/errors.json b/packages/svelte/tests/validator/samples/ts-unsupported-accessor/errors.json
@@ -1,7 +1,7 @@
 [
 	{
 		"code": "typescript_invalid_feature",
-		"message": "TypeScript language features like accessor fields (related TSC proposal is not stage 4 yet) are not natively supported, and their use is generally discouraged. You will need to use a preprocessor to convert it to JavaScript before it gets passed to the Svelte compiler",
+		"message": "TypeScript language features like accessor fields (related TSC proposal is not stage 4 yet) are not natively supported, and their use is generally discouraged. Outside of `<script>` tags, these features are not supported. For use within `<script>` tags, you will need to use a preprocessor to convert it to JavaScript before it gets passed to the Svelte compiler. If you are using `vitePreprocess`, make sure to specifically enable preprocessing script tags (`vitePreprocess({ script: true })`)",
 		"start": {
 			"line": 3,
 			"column": 2
diff --git a/packages/svelte/tests/validator/samples/ts-unsupported-decorator/errors.json b/packages/svelte/tests/validator/samples/ts-unsupported-decorator/errors.json
@@ -1,7 +1,7 @@
 [
 	{
 		"code": "typescript_invalid_feature",
-		"message": "TypeScript language features like decorators (related TSC proposal is not stage 4 yet) are not natively supported, and their use is generally discouraged. You will need to use a preprocessor to convert it to JavaScript before it gets passed to the Svelte compiler",
+		"message": "TypeScript language features like decorators (related TSC proposal is not stage 4 yet) are not natively supported, and their use is generally discouraged. Outside of `<script>` tags, these features are not supported. For use within `<script>` tags, you will need to use a preprocessor to convert it to JavaScript before it gets passed to the Svelte compiler. If you are using `vitePreprocess`, make sure to specifically enable preprocessing script tags (`vitePreprocess({ script: true })`)",
 		"start": {
 			"line": 2,
 			"column": 4
diff --git a/packages/svelte/tests/validator/samples/ts-unsupported-enum/errors.json b/packages/svelte/tests/validator/samples/ts-unsupported-enum/errors.json
@@ -1,7 +1,7 @@
 [
 	{
 		"code": "typescript_invalid_feature",
-		"message": "TypeScript language features like enums are not natively supported, and their use is generally discouraged. You will need to use a preprocessor to convert it to JavaScript before it gets passed to the Svelte compiler",
+		"message": "TypeScript language features like enums are not natively supported, and their use is generally discouraged. Outside of `<script>` tags, these features are not supported. For use within `<script>` tags, you will need to use a preprocessor to convert it to JavaScript before it gets passed to the Svelte compiler. If you are using `vitePreprocess`, make sure to specifically enable preprocessing script tags (`vitePreprocess({ script: true })`)",
 		"start": {
 			"line": 2,
 			"column": 1
diff --git a/packages/svelte/tests/validator/samples/ts-unsupported-modifier/errors.json b/packages/svelte/tests/validator/samples/ts-unsupported-modifier/errors.json
@@ -1,7 +1,7 @@
 [
 	{
 		"code": "typescript_invalid_feature",
-		"message": "TypeScript language features like accessibility modifiers on constructor parameters are not natively supported, and their use is generally discouraged. You will need to use a preprocessor to convert it to JavaScript before it gets passed to the Svelte compiler",
+		"message": "TypeScript language features like accessibility modifiers on constructor parameters are not natively supported, and their use is generally discouraged. Outside of `<script>` tags, these features are not supported. For use within `<script>` tags, you will need to use a preprocessor to convert it to JavaScript before it gets passed to the Svelte compiler. If you are using `vitePreprocess`, make sure to specifically enable preprocessing script tags (`vitePreprocess({ script: true })`)",
 		"start": {
 			"line": 3,
 			"column": 14
diff --git a/packages/svelte/tests/validator/samples/ts-unsupported-namespace/errors.json b/packages/svelte/tests/validator/samples/ts-unsupported-namespace/errors.json
@@ -1,7 +1,7 @@
 [
 	{
 		"code": "typescript_invalid_feature",
-		"message": "TypeScript language features like namespaces with non-type nodes are not natively supported, and their use is generally discouraged. You will need to use a preprocessor to convert it to JavaScript before it gets passed to the Svelte compiler",
+		"message": "TypeScript language features like namespaces with non-type nodes are not natively supported, and their use is generally discouraged. Outside of `<script>` tags, these features are not supported. For use within `<script>` tags, you will need to use a preprocessor to convert it to JavaScript before it gets passed to the Svelte compiler. If you are using `vitePreprocess`, make sure to specifically enable preprocessing script tags (`vitePreprocess({ script: true })`)",
 		"start": {
 			"line": 2,
 			"column": 1

Original file line number	Diff line number	Diff line change
@@ -162,4 +162,4 @@ Using a `$` prefix to refer to the value of a store is only possible inside `.sv
`162`	`162`
`163`	`163`	`## typescript_invalid_feature`
`164`	`164`
`165`		`-> TypeScript language features like %feature% are not natively supported, and their use is generally discouraged. You will need to use a preprocessor to convert it to JavaScript before it gets passed to the Svelte compiler`
	`165`	+> TypeScript language features like %feature% are not natively supported, and their use is generally discouraged. Outside of `<script>` tags, these features are not supported. For use within `<script>` tags, you will need to use a preprocessor to convert it to JavaScript before it gets passed to the Svelte compiler. If you are using `vitePreprocess`, make sure to specifically enable preprocessing script tags (`vitePreprocess({ script: true })`)
Original file line number	Diff line number	Diff line change
`@@ -435,13 +435,13 @@ export function store_invalid_subscription_module(node) {`
`435`	`435`	`}`
`436`	`436`
`437`	`437`	`/**`
`438`		`- * TypeScript language features like %feature% are not natively supported, and their use is generally discouraged. You will need to use a preprocessor to convert it to JavaScript before it gets passed to the Svelte compiler`
	`438`	+ * TypeScript language features like %feature% are not natively supported, and their use is generally discouraged. Outside of `<script>` tags, these features are not supported. For use within `<script>` tags, you will need to use a preprocessor to convert it to JavaScript before it gets passed to the Svelte compiler. If you are using `vitePreprocess`, make sure to specifically enable preprocessing script tags (`vitePreprocess({ script: true })`)
`439`	`439`	`* @param {null \| number \| NodeLike} node`
`440`	`440`	`* @param {string} feature`
`441`	`441`	`* @returns {never}`
`442`	`442`	`*/`
`443`	`443`	`export function typescript_invalid_feature(node, feature) {`
`444`		- e(node, "typescript_invalid_feature", `TypeScript language features like ${feature} are not natively supported, and their use is generally discouraged. You will need to use a preprocessor to convert it to JavaScript before it gets passed to the Svelte compiler`);
	`444`	+ e(node, "typescript_invalid_feature", `TypeScript language features like ${feature} are not natively supported, and their use is generally discouraged. Outside of \`<script>\` tags, these features are not supported. For use within \`<script>\` tags, you will need to use a preprocessor to convert it to JavaScript before it gets passed to the Svelte compiler. If you are using \`vitePreprocess\`, make sure to specifically enable preprocessing script tags (\`vitePreprocess({ script: true })\`)`);
`445`	`445`	`}`
`446`	`446`
`447`	`447`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`[`
`2`	`2`	`{`
`3`	`3`	`"code": "typescript_invalid_feature",`
`4`		`- "message": "TypeScript language features like accessor fields (related TSC proposal is not stage 4 yet) are not natively supported, and their use is generally discouraged. You will need to use a preprocessor to convert it to JavaScript before it gets passed to the Svelte compiler",`
	`4`	+ "message": "TypeScript language features like accessor fields (related TSC proposal is not stage 4 yet) are not natively supported, and their use is generally discouraged. Outside of `<script>` tags, these features are not supported. For use within `<script>` tags, you will need to use a preprocessor to convert it to JavaScript before it gets passed to the Svelte compiler. If you are using `vitePreprocess`, make sure to specifically enable preprocessing script tags (`vitePreprocess({ script: true })`)",
`5`	`5`	`"start": {`
`6`	`6`	`"line": 3,`
`7`	`7`	`"column": 2`