simplify options reading

Author: Bladesheng

packages/svelte/src/compiler/phases/1-parse/read/options.js

@@ -133,47 +133,12 @@ export default function read_options(node) {
 
 				const shadow = properties.find(([name]) => name === 'shadow')?.[1];
 				if (shadow) {
-					if (shadow.type === 'Literal') {
-						if (shadow.value !== 'open' && shadow.value !== 'none') {
-							e.svelte_options_invalid_customelement_shadow(attribute);
-						}
+					if (shadow.type === 'Literal' && (shadow.value === 'open' || shadow.value === 'none')) {
 						ce.shadow = shadow.value;
-					} else if (shadow.type === 'ObjectExpression') {
-						ce.shadow = { mode: 'open' };
-						for (const property of /** @type {ObjectExpression} */ (shadow).properties) {
-							if (
-								property.type !== 'Property' ||
-								property.computed ||
-								property.key.type !== 'Identifier' ||
-								property.value.type !== 'Literal'
-							) {
-								e.svelte_options_invalid_customelement_shadow(attribute);
-							}
-
-							if (property.key.name === 'mode') {
-								if (!['open', 'closed'].includes(/** @type {string} */ (property.value.value))) {
-									e.svelte_options_invalid_customelement_shadow(attribute);
-								}
-								ce.shadow.mode = /** @type {any} */ (property.value.value);
-							} else if (property.key.name === 'slotAssignment') {
-								if (!['named', 'manual'].includes(/** @type {string} */ (property.value.value))) {
-									e.svelte_options_invalid_customelement_shadow(attribute);
-								}
-								ce.shadow.slotAssignment = /** @type {any} */ (property.value.value);
-							} else if (
-								property.key.name === 'clonable' ||
-								property.key.name === 'delegatesFocus' ||
-								property.key.name === 'serializable'
-							) {
-								if (typeof property.value.value !== 'boolean') {
-									e.svelte_options_invalid_customelement_shadow(attribute);
-								}
-								ce.shadow[property.key.name] = property.value.value;
-							} else {
-								e.svelte_options_invalid_customelement_shadow(attribute);
-							}
-						}
-					} else if (shadow.type === 'ArrowFunctionExpression') {
+					} else if (
+						shadow.type === 'ObjectExpression' ||
+						shadow.type === 'ArrowFunctionExpression'
+					) {
 						ce.shadow = shadow;
 					} else {
 						e.svelte_options_invalid_customelement_shadow(attribute);

packages/svelte/src/compiler/phases/3-transform/client/transform-client.js

@@ -645,22 +645,13 @@ export function client_component(analysis, options) {
 		);
 
 		/** @type {ESTree.ObjectExpression | ESTree.ArrowFunctionExpression | undefined} */
-		let shadow_root_init = undefined;
+		let shadow_root_init;
 		if (typeof ce === 'boolean' || ce.shadow === 'open' || ce.shadow === undefined) {
 			shadow_root_init = b.object([b.init('mode', b.literal('open'))]);
 		} else if (ce.shadow === 'none') {
 			shadow_root_init = undefined;
-		} else if ('type' in ce.shadow && ce.shadow.type === 'ArrowFunctionExpression') {
-			shadow_root_init = /** @type {ESTree.ArrowFunctionExpression} */ (ce.shadow);
-		} else if (typeof ce.shadow === 'object') {
-			/** @type {ESTree.Property[]} */
-			const shadow_root_init_props = Object.entries(ce.shadow).map(([key, value]) =>
-				b.init(key, b.literal(value))
-			);
-
-			shadow_root_init = shadow_root_init_props.length
-				? b.object(shadow_root_init_props)
-				: undefined;
+		} else {
+			shadow_root_init = ce.shadow;
 		}
 
 		const create_ce = b.call(

packages/svelte/src/compiler/types/template.d.ts

@@ -88,11 +88,7 @@ export namespace AST {
 		css?: 'injected';
 		customElement?: {
 			tag?: string;
-			shadow?:
-				| 'open'
-				| 'none'
-				| (ShadowRootInit & { clonable?: boolean })
-				| ArrowFunctionExpression;
+			shadow?: 'open' | 'none' | ObjectExpression | ArrowFunctionExpression | undefined;
 			props?: Record<
 				string,
 				{

packages/svelte/types/index.d.ts

@@ -1224,11 +1224,7 @@ declare module 'svelte/compiler' {
 			css?: 'injected';
 			customElement?: {
 				tag?: string;
-				shadow?:
-					| 'open'
-					| 'none'
-					| (ShadowRootInit & { clonable?: boolean })
-					| ArrowFunctionExpression;
+				shadow?: 'open' | 'none' | ObjectExpression | ArrowFunctionExpression | undefined;
 				props?: Record<
 					string,
 					{