Skip to content

Commit 0f41689

Browse files
authored
chore: unskip more tests (#12621)
1 parent e1728e5 commit 0f41689

File tree

10 files changed

+16
-44
lines changed

10 files changed

+16
-44
lines changed

packages/svelte/tests/css/samples/supports-nested-page/_config.js

Lines changed: 0 additions & 6 deletions
This file was deleted.

packages/svelte/tests/runtime-browser/custom-elements-samples/escaped-css/_config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { test } from '../../assert';
22
const tick = () => Promise.resolve();
33

44
export default test({
5-
skip: true, // TODO: needs inline CSS, decide how to add
65
async test({ assert, target }) {
76
target.innerHTML = '<custom-element></custom-element>';
87
await tick();

packages/svelte/tests/runtime-legacy/samples/action-update-before-destroy/_config.js

Lines changed: 4 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -2,28 +2,16 @@ import { flushSync } from 'svelte';
22
import { test } from '../../test';
33

44
export default test({
5-
skip: true, // TODO: needs fixing
6-
75
html: `
86
<button>Click Me</button>
97
<div>1</div>
108
`,
11-
async test({ assert, target, window }) {
9+
async test({ assert, target, logs }) {
1210
const button = target.querySelector('button');
13-
const event = new window.MouseEvent('click');
14-
/**
15-
* @type {any[]}
16-
*/
17-
const messages = [];
18-
const log = console.log;
19-
console.log = (msg) => messages.push(msg);
2011

21-
flushSync(() => {
22-
// @ts-ignore
23-
button.dispatchEvent(event);
24-
});
12+
button?.click();
13+
flushSync();
2514

26-
console.log = log;
27-
assert.deepEqual(messages, ['afterUpdate', 'onDestroy']);
15+
assert.deepEqual(logs, ['afterUpdate', 'onDestroy']);
2816
}
2917
});

packages/svelte/tests/runtime-legacy/samples/animation-css/_config.js

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
1-
// @ts-nocheck
21
import { test } from '../../test';
32

43
export default test({
5-
skip: true, // TODO: needs fixing
6-
74
get props() {
85
return {
96
things: [
@@ -27,7 +24,9 @@ export default test({
2724
test({ assert, component, target, raf }) {
2825
let divs = target.querySelectorAll('div');
2926
divs.forEach((div) => {
27+
// @ts-expect-error
3028
div.getBoundingClientRect = function () {
29+
// @ts-expect-error
3130
const index = [...this.parentNode.children].indexOf(this);
3231
const top = index * 30;
3332

@@ -49,13 +48,13 @@ export default test({
4948
];
5049

5150
divs = target.querySelectorAll('div');
52-
assert.ok(~divs[0].style.animation.indexOf('__svelte'));
53-
assert.equal(divs[1].style.animation, '');
54-
assert.equal(divs[2].style.animation, '');
55-
assert.equal(divs[3].style.animation, '');
56-
assert.ok(~divs[4].style.animation.indexOf('__svelte'));
51+
assert.ok(divs[0].getAnimations().length > 0);
52+
assert.equal(divs[1].getAnimations().length, 0);
53+
assert.equal(divs[2].getAnimations().length, 0);
54+
assert.equal(divs[3].getAnimations().length, 0);
55+
assert.ok(divs[4].getAnimations().length > 0);
5756

5857
raf.tick(100);
59-
assert.deepEqual([divs[0].style.animation, divs[4].style.animation], ['', '']);
58+
assert.deepEqual([divs[0].getAnimations().length, divs[4].getAnimations().length], [0, 0]);
6059
}
6160
});

packages/svelte/tests/runtime-legacy/samples/before-render-chain/_config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { test } from '../../test';
22

33
export default test({
4-
skip: true, // TODO: needs fixing
4+
mode: ['client', 'hydrate'],
55

66
html: `
77
<span>3</span>

packages/svelte/tests/runtime-legacy/samples/dev-warning-readonly-computed/_config.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
import { test } from '../../test';
22

33
export default test({
4-
skip: true, // TODO: needs fixing, error message is wrong
5-
64
compileOptions: {
75
dev: true
86
},
@@ -17,7 +15,7 @@ export default test({
1715
throw new Error('Expected an error');
1816
} catch (err) {
1917
// @ts-ignore
20-
assert.equal(err.message, "<Main>: Cannot set read-only property 'foo'");
18+
assert.equal(err.message, 'Cannot set property foo of #<Object> which has only a getter');
2119
}
2220
}
2321
});

packages/svelte/tests/runtime-legacy/samples/dynamic-element-svg-implicit-namespace/_config.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,7 @@
11
import { test } from '../../test';
22

33
export default test({
4-
// This is skipped for now, because it's not clear how to make this work on client-side initial run:
5-
// The anchor isn't connected to its parent at the time we can do a runtime check for the namespace, and we
6-
// need the parent for this check. (this didn't work in Svelte 4 either)
7-
skip: true,
8-
html: '<svg><path></path></svg>',
4+
html: '<svg xmlns="http://www.w3.org/2000/svg"><path></path></svg>',
95

106
test({ assert, target }) {
117
const svg = target.querySelector('svg');

packages/svelte/tests/runtime-legacy/samples/dynamic-element-svg-implicit-namespace/main.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,6 @@
55
export let path = 'path';
66
</script>
77

8-
<svelte:element this={svg}>
8+
<svelte:element this={svg} xmlns="http://www.w3.org/2000/svg">
99
<svelte:element this={path}></svelte:element>
1010
</svelte:element>

packages/svelte/tests/validator/samples/general-siblings-combinator-in-custom-element-selects-slot-fallback/_config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { test } from '../../test';
22

33
export default test({
4-
skip: true,
54
compileOptions: {
65
customElement: true
76
}

packages/svelte/tests/validator/samples/siblings-combinator-in-custom-element-selects-slot-fallback/_config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import { test } from '../../test';
22

33
export default test({
4-
skip: true,
54
compileOptions: {
65
customElement: true
76
}

0 commit comments

Comments
 (0)