Added support for filtering unused named imports. #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaartenX
force-pushed
the
import-interfaces
branch
from
6cccb21 to
49c121c
Compare
MaartenX
commented
May 24, 2020
MaartenX
force-pushed
the
import-interfaces
branch
14 times, most recently
from
44680a4 to
c193100
Compare
ghost
reviewed
May 26, 2020
src/processors/typescript.ts
Outdated
| const transformed = await transformer({ | ||
| content, | ||
| filename, | ||
| markup: markupCache[svelteFile.filename], |
There was a problem hiding this comment.
Hi, as a suggestion, I'd move the additional parameter to the end of the param list to be consistent with your additions to other param lists earlier in the file.
MaartenX
force-pushed
the
import-interfaces
branch
from
c193100 to
cf2177a
Compare
kaisermann
force-pushed
the
master
branch
2 times, most recently
from
2d63489 to
bdd8bb0
Compare
added 2 commits
May 29, 2020 09:35
Uses the AST to check if named imports are used in the transpiled code. If not, filters out the import. This way non-emitting types will never be imported so we don't get the following error: ```[!] Error: '<Interface>' is not exported by <TypeScriptFile>.ts, imported by <SvelteFile>.svelte```
MaartenX
force-pushed
the
import-interfaces
branch
from
cf2177a to
ae7c462
Compare
|
This will make the pre-processor much more useful, I run into this ALL THE TIME :) |
|
I'm not 100% on all the problems this solves, but can recommending |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the AST to check if named imports are used in the transpiled code. If not, filters out the named import. Another option could be to use the typechecker, but then it would break when transpileOnly was true.
Fixes #153.
This way non-emitting types will never be imported so we don't get the following error:
[!] Error: '<Interface>' is not exported by <TypeScriptFile>.ts, imported by <SvelteFile>.svelteBefore submitting the PR, please make sure you do the following
npm run lint!)Tests
npm testoryarn test