Skip to content

fix?(splitter): allow newlines after commas #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

fix?(splitter): allow newlines after commas #380

merged 1 commit into from
Apr 30, 2025

Conversation

juleswritescode
Copy link
Collaborator

@juleswritescode juleswritescode commented Apr 30, 2025 •
edited
Loading

looks like we can assume that it's always a statement if there's a comma before the newlines?

select
            email,



        from
            auth.users;

Note that this doesn't fix this one – it's apparently not a splitter-problem, the file is correclty parsed as a single statement

juleswritescode
juleswritescode commented Apr 30, 2025
View reviewed changes
psteinroe
psteinroe approved these changes Apr 30, 2025
View reviewed changes
Copy link
Collaborator

@psteinroe psteinroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea, thanks!!

@juleswritescode juleswritescode merged commit b8a0986 into main Apr 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psteinroe psteinroe psteinroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Blank lines between common table expressions (CTEs) misreported as syntax error
2 participants
@juleswritescode @psteinroe