Skip to content

fix: use byte indices #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 3, 2025
Merged

fix: use byte indices #286

merged 5 commits into from
Apr 3, 2025

Conversation

psteinroe
Copy link
Collaborator

@psteinroe psteinroe commented Mar 31, 2025 •
edited
Loading

closes #281

we need to use byte indices

@psteinroe psteinroe marked this pull request as ready for review April 1, 2025 11:31
@psteinroe psteinroe changed the title try to add repro fix: use byte indices Apr 1, 2025
juleswritescode
juleswritescode approved these changes Apr 1, 2025
View reviewed changes
Copy link
Collaborator

@juleswritescode juleswritescode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! get_affected_content(content: &'a str, range: Range) -> &'a str helper method maybe?

juleswritescode
juleswritescode reviewed Apr 1, 2025
View reviewed changes
@psteinroe psteinroe merged commit 0fde3aa into main Apr 3, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juleswritescode juleswritescode juleswritescode approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Server crashes when Cyrillic character is typed
2 participants
@psteinroe @juleswritescode