progress

Author: psteinroe

crates/pgt_statement_splitter/benches/splitter.rs

@@ -2,8 +2,7 @@ use criterion::{Criterion, black_box, criterion_group, criterion_main};
 use pgt_statement_splitter::split;
 
 pub fn splitter_benchmark(c: &mut Criterion) {
-    c.bench_function("large statement", |b| {
-        let statement = r#"with
+    let large_statement = r#"with
   available_tables as (
     select
       c.relname as table_name,
@@ -62,18 +61,24 @@ where
 
 "#;
 
-        let content = statement.repeat(500);
+    let large_content = large_statement.repeat(500);
 
-        b.iter(|| black_box(split(&content)));
-    });
+    c.bench_function(
+        format!("large statement with length {}", large_content.len()).as_str(),
+        |b| {
+            b.iter(|| black_box(split(&large_content)));
+        },
+    );
 
-    c.bench_function("small statement", |b| {
-        let statement = r#"select 1 from public.user where id = 1"#;
+    let small_statement = r#"select 1 from public.user where id = 1"#;
+    let small_content = small_statement.repeat(500);
 
-        let content = statement.repeat(500);
-
-        b.iter(|| black_box(split(&content)));
-    });
+    c.bench_function(
+        format!("small statement with length {}", small_content.len()).as_str(),
+        |b| {
+            b.iter(|| black_box(split(&small_content)));
+        },
+    );
 }
 
 criterion_group!(benches, splitter_benchmark);

crates/pgt_workspace/src/workspace/server/document.rs

@@ -155,7 +155,7 @@ where
 
             if let Ok(ast) = self.parser.ast_db.get_or_cache_ast(&root_id).as_ref() {
                 // Check if this is a SQL function definition with a body
-                if let Some(sub_statement) = get_sql_fn_body(ast, &content) {
+                if let Some(sub_statement) = get_sql_fn_body(ast, content) {
                     // Add sub-statements to our pending queue
                     self.pending_sub_statements.push((
                         root_id.create_child(&sub_statement.body),