chore: merge main

Author: psteinroe

Cargo.lock

@@ -37,7 +37,7 @@ sqlx                     = { version = "0.8.2", features = ["runtime-async-std",
 syn                      = "1.0.109"
 termcolor                = "1.4.1"
 text-size                = "1.1.1"
-tokio                    = "1.40.0"
+tokio                    = { version = "1.40.0", features = ["full"] }
 toml                     = "0.8.19"
 tower-lsp                = "0.20.0"
 tracing                  = { version = "0.1.40", default-features = false, features = ["std"] }

Cargo.toml

@@ -44,17 +44,20 @@ Once the parser is stable, and a robust and scalable data model is implemented,
 Add the postgres_lsp executable to your path, and add the following to your config to use it.
 
 ```lua
+local util = require 'lspconfig.util'
+local lspconfig = require 'lspconfig'
+
 require('lspconfig.configs').postgres_lsp = {
   default_config = {
     name = 'postgres_lsp',
-    cmd = {'postgres_lsp'},
-    filetypes = {'sql'},
+    cmd = { 'postgres_lsp' },
+    filetypes = { 'sql' },
     single_file_support = true,
-    root_dir = util.root_pattern 'root-file.txt'
-  }
+    root_dir = util.root_pattern 'root-file.txt',
+  },
 }
 
-lsp.configure("postgres_lsp", {force_setup = true})
+lspconfig.postgres_lsp.setup { force_setup = true }
 ```
 
 ### Building from source

README.md

@@ -90,6 +90,7 @@ pub enum TraversalMode {
         /// It's [None] if the `check` command is called without `--apply` or `--apply-suggested`
         /// arguments.
         // fix_file_mode: Option<FixFileMode>,
+
         /// An optional tuple.
         /// 1. The virtual path to the file
         /// 2. The content of the file

crates/pg_cli/src/execute/mod.rs

@@ -17,14 +17,16 @@ async-std = "1.12.0"
 text-size.workspace = true
 
 pg_schema_cache.workspace = true
-pg_test_utils.workspace   = true
 tree-sitter.workspace     = true
 tree_sitter_sql.workspace = true
 
 sqlx.workspace = true
 
 tokio = { version = "1.41.1", features = ["full"] }
 
+[dev-dependencies]
+pg_test_utils.workspace = true
+
 [lib]
 doctest = false
 

crates/pg_completions/Cargo.toml

@@ -28,7 +28,7 @@ impl CompletionBuilder {
             .enumerate()
             .map(|(idx, mut item)| {
                 if idx == 0 {
-                    item.preselected = Some(should_preselect_first_item);
+                    item.preselected = should_preselect_first_item;
                 }
                 item
             })

crates/pg_completions/src/builder.rs

@@ -1,8 +1,10 @@
 use text_size::TextSize;
 
 use crate::{
-    builder::CompletionBuilder, context::CompletionContext, item::CompletionItem,
-    providers::complete_tables,
+    builder::CompletionBuilder,
+    context::CompletionContext,
+    item::CompletionItem,
+    providers::{complete_functions, complete_tables},
 };
 
 pub const LIMIT: usize = 50;
@@ -11,7 +13,7 @@ pub const LIMIT: usize = 50;
 pub struct CompletionParams<'a> {
     pub position: TextSize,
     pub schema: &'a pg_schema_cache::SchemaCache,
-    pub text: &'a str,
+    pub text: String,
     pub tree: Option<&'a tree_sitter::Tree>,
 }
 
@@ -34,186 +36,7 @@ pub fn complete(params: CompletionParams) -> CompletionResult {
     let mut builder = CompletionBuilder::new();
 
     complete_tables(&ctx, &mut builder);
+    complete_functions(&ctx, &mut builder);
 
     builder.finish()
 }
-
-#[cfg(test)]
-mod tests {
-    use pg_schema_cache::SchemaCache;
-    use pg_test_utils::test_database::*;
-
-    use sqlx::Executor;
-
-    use crate::{complete, CompletionParams};
-
-    #[tokio::test]
-    async fn autocompletes_simple_table() {
-        let test_db = get_new_test_db().await;
-
-        let setup = r#"
-            create table users (
-                id serial primary key,
-                name text,
-                password text
-            );
-        "#;
-
-        test_db
-            .execute(setup)
-            .await
-            .expect("Failed to execute setup query");
-
-        let input = "select * from u";
-
-        let mut parser = tree_sitter::Parser::new();
-        parser
-            .set_language(tree_sitter_sql::language())
-            .expect("Error loading sql language");
-
-        let tree = parser.parse(input, None).unwrap();
-        let schema_cache = SchemaCache::load(&test_db).await;
-
-        let p = CompletionParams {
-            position: ((input.len() - 1) as u32).into(),
-            schema: &schema_cache,
-            text: input,
-            tree: Some(&tree),
-        };
-
-        let result = complete(p);
-
-        assert!(!result.items.is_empty());
-
-        let best_match = &result.items[0];
-
-        assert_eq!(
-            best_match.label, "users",
-            "Does not return the expected table to autocomplete: {}",
-            best_match.label
-        )
-    }
-
-    #[tokio::test]
-    async fn autocompletes_table_alphanumerically() {
-        let test_db = get_new_test_db().await;
-
-        let setup = r#"
-            create table addresses (
-                id serial primary key
-            );
-
-            create table users (
-                id serial primary key
-            );
-
-            create table emails (
-                id serial primary key
-            );
-        "#;
-
-        test_db
-            .execute(setup)
-            .await
-            .expect("Failed to execute setup query");
-
-        let schema_cache = SchemaCache::load(&test_db).await;
-
-        let mut parser = tree_sitter::Parser::new();
-        parser
-            .set_language(tree_sitter_sql::language())
-            .expect("Error loading sql language");
-
-        let test_cases = vec![
-            ("select * from us", "users"),
-            ("select * from em", "emails"),
-            ("select * from ", "addresses"),
-        ];
-
-        for (input, expected_label) in test_cases {
-            let tree = parser.parse(input, None).unwrap();
-
-            let p = CompletionParams {
-                position: ((input.len() - 1) as u32).into(),
-                schema: &schema_cache,
-                text: input,
-                tree: Some(&tree),
-            };
-
-            let result = complete(p);
-
-            assert!(!result.items.is_empty());
-
-            let best_match = &result.items[0];
-
-            assert_eq!(
-                best_match.label, expected_label,
-                "Does not return the expected table to autocomplete: {}",
-                best_match.label
-            )
-        }
-    }
-
-    #[tokio::test]
-    async fn autocompletes_table_with_schema() {
-        let test_db = get_new_test_db().await;
-
-        let setup = r#"
-            create schema customer_support;
-            create schema private;
-
-            create table private.user_z (
-                id serial primary key,
-                name text,
-                password text
-            );
-
-            create table customer_support.user_y (
-                id serial primary key,
-                request text,
-                send_at timestamp with time zone
-            );
-        "#;
-
-        test_db
-            .execute(setup)
-            .await
-            .expect("Failed to execute setup query");
-
-        let schema_cache = SchemaCache::load(&test_db).await;
-
-        let mut parser = tree_sitter::Parser::new();
-        parser
-            .set_language(tree_sitter_sql::language())
-            .expect("Error loading sql language");
-
-        let test_cases = vec![
-            ("select * from u", "user_y"), // user_y is preferred alphanumerically
-            ("select * from private.u", "user_z"),
-            ("select * from customer_support.u", "user_y"),
-        ];
-
-        for (input, expected_label) in test_cases {
-            let tree = parser.parse(input, None).unwrap();
-
-            let p = CompletionParams {
-                position: ((input.len() - 1) as u32).into(),
-                schema: &schema_cache,
-                text: input,
-                tree: Some(&tree),
-            };
-
-            let result = complete(p);
-
-            assert!(!result.items.is_empty());
-
-            let best_match = &result.items[0];
-
-            assert_eq!(
-                best_match.label, expected_label,
-                "Does not return the expected table to autocomplete: {}",
-                best_match.label
-            )
-        }
-    }
-}