🐛(tree-view) enhance useTree hook to manage children references #61
+37
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update improves the useTree hook by ensuring that children references in the tree data are correctly replaced. It adds logic to handle cases where children may have already been loaded without triggering the loadChildren function. The childrenCount is now calculated based on whether the children have been loaded, and the hasLoadedChildren flag is set appropriately. This change enhances the efficiency of tree data management.
NathanVss
reviewed
Apr 7, 2025
Comment on lines
+253
to
+287
| /** | ||
| * The tree might have already been loaded without going through loadChildren. (if we loaded the entire tree or part of the tree for example) | ||
| * In this case, hasLoadedChildren is not set but the children are loaded. | ||
| */ | ||
| const hasLoadedChildren = | ||
| item.value.hasLoadedChildren || | ||
| item.children?.length > 0 || | ||
| (item.value.children && item.value.children.length > 0); | ||
|
|
||
| item.value.children = item.children.map((child) => child.value); | ||
|
|
||
| const childrenCount = hasLoadedChildren | ||
| ? item.children.length | ||
| : item.value.childrenCount ?? 0; | ||
|
|
||
| item.value.childrenCount = childrenCount; | ||
|
|
||
| // If the children have been loaded but the hasLoadedChildren is not set, set it to true. | ||
| if (hasLoadedChildren && !item.value.hasLoadedChildren) { | ||
| item.value.hasLoadedChildren = true; | ||
| } | ||
| // Recursively process children | ||
|
|
||
| replaceChildrenReferences(item.children); | ||
| } else { | ||
| // Same as above | ||
| const hasLoadedChildren = | ||
| item.value.hasLoadedChildren || | ||
| (item.value.children && item.value.children.length > 0); | ||
|
|
||
| const childrenCount = hasLoadedChildren | ||
| ? 0 | ||
| : item.value.childrenCount; | ||
|
|
||
| item.value.children = []; | ||
| item.value.childrenCount = childrenCount; |
There was a problem hiding this comment.
Can't you find a way to avoid having to two code blocks logic that seems to do the same thing inside the "if" and the "else"?
It seems that the logic is a bit duplicated, but I'm not sure if I'm missing a point, maybe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update improves the useTree hook by ensuring that children references in the tree data are correctly replaced. It adds logic to handle cases where children may have already been loaded without triggering the loadChildren function. The childrenCount is now calculated based on whether the children have been loaded, and the hasLoadedChildren flag is set appropriately. This change enhances the efficiency of tree data management.