File tree Expand file tree Collapse file tree 2 files changed +15
-7
lines changed
e2e/__tests__/app-impress
impress/src/features/docs/doc-share/components Expand file tree Collapse file tree 2 files changed +15
-7
lines changed Original file line number Diff line number Diff line change @@ -52,6 +52,12 @@ test.describe('Inherited share accesses', () => {
5252 await expect ( docVisibilityCard . getByText ( 'Connected' ) ) . toBeVisible ( ) ;
5353 await expect ( docVisibilityCard . getByText ( 'Reading' ) ) . toBeVisible ( ) ;
5454
55+ await docVisibilityCard . getByText ( 'Reading' ) . click ( ) ;
56+ await page . getByRole ( 'menuitem' , { name : 'Editing' } ) . click ( ) ;
57+
58+ await expect ( docVisibilityCard . getByText ( 'Reading' ) ) . toBeHidden ( ) ;
59+ await expect ( docVisibilityCard . getByText ( 'Editing' ) ) . toBeVisible ( ) ;
60+
5561 // Verify inherited link
5662 await docVisibilityCard . getByText ( 'Connected' ) . click ( ) ;
5763 await expect (
@@ -61,17 +67,13 @@ test.describe('Inherited share accesses', () => {
6167 // Update child link
6268 await page . getByRole ( 'menuitem' , { name : 'Public' } ) . click ( ) ;
6369
64- await docVisibilityCard . getByText ( 'Reading' ) . click ( ) ;
65- await page . getByRole ( 'menuitem' , { name : 'Editing' } ) . click ( ) ;
66-
6770 await expect ( docVisibilityCard . getByText ( 'Connected' ) ) . toBeHidden ( ) ;
68- await expect ( docVisibilityCard . getByText ( 'Reading' ) ) . toBeHidden ( ) ;
6971 await expect (
7072 docVisibilityCard . getByText ( 'Public' , {
7173 exact : true ,
7274 } ) ,
7375 ) . toBeVisible ( ) ;
74- await expect ( docVisibilityCard . getByText ( 'Editing' ) ) . toBeVisible ( ) ;
76+
7577 await expect (
7678 docVisibilityCard . getByText (
7779 'The link sharing rules differ from the parent document' ,
Original file line number Diff line number Diff line change @@ -17,6 +17,7 @@ import {
1717 LinkReach ,
1818 LinkRole ,
1919 getDocLinkReach ,
20+ getDocLinkRole ,
2021 useDocUtils ,
2122 useUpdateDocLink ,
2223} from '@/docs/doc-management' ;
@@ -36,7 +37,7 @@ export const DocVisibility = ({ doc }: DocVisibilityProps) => {
3637 const { spacingsTokens, colorsTokens } = useCunninghamTheme ( ) ;
3738 const canManage = doc . abilities . accesses_manage ;
3839 const docLinkReach = getDocLinkReach ( doc ) ;
39- const docLinkRole = doc . computed_link_role ?? LinkRole . READER ;
40+ const docLinkRole = getDocLinkRole ( doc ) ;
4041 const { isDesynchronized } = useDocUtils ( doc ) ;
4142 const { linkModeTranslations, linkReachChoices, linkReachTranslations } =
4243 useTranslatedShareSettings ( ) ;
@@ -85,7 +86,12 @@ export const DocVisibility = ({ doc }: DocVisibilityProps) => {
8586 const isDisabled = ! options . includes ( key ) ;
8687 return {
8788 label : linkModeTranslations [ key ] ,
88- callback : ( ) => updateDocLink ( { id : doc . id , link_role : key } ) ,
89+ callback : ( ) =>
90+ updateDocLink ( {
91+ id : doc . id ,
92+ link_role : key ,
93+ link_reach : docLinkReach ,
94+ } ) ,
8995 isSelected : docLinkRole === key ,
9096 disabled : isDisabled ,
9197 } ;
You can’t perform that action at this time.
0 commit comments