Skip to content

Various fixes and improvements #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Various fixes and improvements #2

wants to merge 2 commits into from

Conversation

sin
Copy link

@sin sin commented Oct 14, 2018

Was going to change "stateless functional components" to "function component", ended up with this mess:

  • fixed typos, punctuation and grammar
  • improved language style, reworded ambiguous sentences and omitted needless words
  • fixed list formatting and other markdown related issues
  • added emphasis and inline code formatting
  • added syntax highlighting
  • simplified some examples
  • unified code style in examples
  • dropped deprecated createClass in examples
  • updated some answers to reflect latest changes in React
  • ReactJS > React
  • and finally… "stateless functional component" > "function component"

muideen and others added 2 commits October 14, 2018 21:50
- fixed typos, punctuation and grammar
- improved language style, reworded ambiguous sentences and omitted needless words
- fixed list formatting and other markdown related issues
- added emphasis and inline code formatting
- added syntax highlighting
- simplified some examples
- unified code style in examples
- dropped deprecated createClass in examples
- updated some answers to reflect latest changes in React
- ReactJS > React
- stateless functional component > function component
Copy link
Owner

@sudheerj sudheerj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for these improvements. There are some conflicts which needs to be resolved. Due to more changes, I was not able able to see the diff. Can you please resolve them. Thanks again.

@sudheerj
Copy link
Owner

I'am going to manually merge these changes due to conflicts. Thanks for the great effort :)

@sudheerj sudheerj closed this Oct 16, 2018
yashints pushed a commit to yashints/reactjs-interview-questions that referenced this pull request May 7, 2020
sudheerj pushed a commit that referenced this pull request Apr 23, 2021
chore: format code style in 282
AndriiKatsarskyi added a commit to AndriiKatsarskyi/reactjs-interview-Q-A that referenced this pull request May 16, 2025
AndriiKatsarskyi added a commit to AndriiKatsarskyi/reactjs-interview-Q-A that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants