Fix error check being in the wrong place

stwiname · stwiname · commit 1ca990240299 · 2025-03-06T10:34:23.000+13:00
diff --git a/eth/filters/api_subql.go b/eth/filters/api_subql.go
@@ -271,10 +271,10 @@ func (api *SubqlAPI) resolveFieldSelector(ctx context.Context, fieldSelector *Fi
 		for _, log := range block.Logs {
 			if _, ok := block.Transactions[hexutil.Uint64(log.TxIndex)]; !ok {
 				_, tx, _, _ /*blockIndex*/, transactionIndex, err := api.backend.GetTransaction(ctx, log.TxHash)
-				rpcTx := ethapi.NewRPCTransaction(tx, block.Header, transactionIndex, api.sys.backend.ChainConfig())
 				if err != nil {
 					return err
 				}
+				rpcTx := ethapi.NewRPCTransaction(tx, block.Header, transactionIndex, api.sys.backend.ChainConfig())
 				logTxs = append(logTxs, &rpcTx)
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -271,10 +271,10 @@ func (api SubqlAPI) resolveFieldSelector(ctx context.Context, fieldSelector Fi`
`271`	`271`	`for _, log := range block.Logs {`
`272`	`272`	`if _, ok := block.Transactions[hexutil.Uint64(log.TxIndex)]; !ok {`
`273`	`273`	`_, tx, _, _ /blockIndex/, transactionIndex, err := api.backend.GetTransaction(ctx, log.TxHash)`
`274`		`- rpcTx := ethapi.NewRPCTransaction(tx, block.Header, transactionIndex, api.sys.backend.ChainConfig())`
`275`	`274`	`if err != nil {`
`276`	`275`	`return err`
`277`	`276`	`}`
	`277`	`+ rpcTx := ethapi.NewRPCTransaction(tx, block.Header, transactionIndex, api.sys.backend.ChainConfig())`
`278`	`278`	`logTxs = append(logTxs, &rpcTx)`
`279`	`279`	`}`
`280`	`280`	`}`