Skip to content

Add support for es6 modules in boot scripts #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Conversation

klarkc
Copy link
Contributor

@klarkc klarkc commented Jun 17, 2018

Description

Add support for compiled es6 modules in boot scripts

Related issues

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@slnode
Copy link

slnode commented Jun 17, 2018

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@klarkc klarkc changed the title Add support for es6 modules for boot scripts Add support for es6 modules in boot scripts Jun 17, 2018
@klarkc klarkc changed the title Add support for es6 modules in boot scripts Add support for UMD in boot scripts Jun 17, 2018
@klarkc klarkc changed the title Add support for UMD in boot scripts Add support for es6 modules in boot scripts Jun 17, 2018
klarkc added a commit to InCuca/vue-loopback that referenced this pull request Jun 17, 2018
@virkt25
Copy link
Contributor

virkt25 commented Jun 18, 2018

ok to test

@klarkc
Copy link
Contributor Author

klarkc commented Jun 19, 2018

There are errors coming from master, should I try to fix them?

@virkt25
Copy link
Contributor

virkt25 commented Jun 19, 2018

If you can that would be great :)

@bajtos
Copy link
Member

bajtos commented Oct 11, 2018

Rebased on top of the latest master. The tests are passing locally for me, let's see what our CI thinks.

@klarkc FWIW, there are more places than just boot scripts where we may need to recognize ES6 default exports - see #250. I am ok to fix those other places incrementally as users start asking for that.

@bajtos bajtos merged commit 0ace54c into strongloop:master Oct 11, 2018
@bajtos
Copy link
Member

bajtos commented Oct 11, 2018

Landed 🎉 Thank you @klarkc for your first contribution! ❤️

Because you send the PR from your master branch, you will need a bit of cleanup work on your side to make your master branch up to date with our master branch (the upstream).

  1. If you don't have strongloop's repository configured as an upstream remote yet:

    $ git remote add upstream https://github.com/strongloop/loopback
    
  2. Fetch the latest updates from upstream:

    $ git fetch upstream
    
  3. Hard-reset your master to upstream:

    $ git checkout master
    $ git reset --hard upstream/master
    
  4. Force-push your changes back to GitHub

    $ git push -f
    

In the future, please create a new feature branch for each pull request. I recommend the following guide for step-by-step instructions showing the recommended contribution workflow: https://www.nearform.com/blog/first-time-with-open-source/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants