Skip to content

Commit fcdcda1

Browse files
strawgatestrawgate
committed
PR Feedback
1 parent 1ed8e03 commit fcdcda1

File tree

1 file changed

+1
-335
lines changed
  • key-value/key-value-shared-test/src/key_value/shared_test

1 file changed

+1
-335
lines changed

‎key-value/key-value-shared-test/src/key_value/shared_test/cases.py‎

Lines changed: 1 addition & 335 deletions
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ def parametrize(cls, cases: list[Self]) -> MarkDecorator:
222222
B64_HELLO_WORLD: str = base64.b64encode(B_HELLO_WORLD).decode(encoding="ascii")
223223

224224
BYTES_CASES: PositiveCases = PositiveCases(
225-
Case(name="no-implicit-conversion-in-keys", data={B64_HELLO_WORLD: "str_value"}, json=f'{{"bytes_key": "{B64_HELLO_WORLD}"}}'),
225+
Case(name="no-implicit-conversion-in-keys", data={B64_HELLO_WORLD: "str_value"}, json=f'{{"{B64_HELLO_WORLD}": "str_value"}}'),
226226
Case(name="no-implicit-conversion-in-values", data={"str_key": B64_HELLO_WORLD}, json=f'{{"str_key": "{B64_HELLO_WORLD}"}}'),
227227
case_type="bytes",
228228
)
@@ -346,337 +346,3 @@ def parametrize(cls, cases: list[Self]) -> MarkDecorator:
346346
NEGATIVE_DATETIME_CASES,
347347
NEGATIVE_UUID_CASES,
348348
]
349-
350-
351-
# SIMPLE
352-
353-
# # ISO format string cases (these test string handling, not datetime object handling)
354-
# # Note: Actual datetime/date/time objects are tested in negative test cases (base.py)
355-
# DATETIME_CASE: Case = Case(
356-
# name="datetime",
357-
# data={"datetime_key": FIXED_DATETIME.isoformat()},
358-
# json='{"datetime_key": "2025-01-01T00:00:00+00:00"}',
359-
# )
360-
# DATE_CASE: Case = Case(
361-
# name="date",
362-
# data={"date_key": FIXED_DATETIME.date().isoformat()},
363-
# json='{"date_key": "2025-01-01"}',
364-
# )
365-
# TIME_CASE: Case = Case(
366-
# name="time",
367-
# data={"time_key": FIXED_TIME.isoformat()},
368-
# json='{"time_key": "00:00:00"}',
369-
# )
370-
371-
# # UUID string case (tests string handling, not UUID object handling)
372-
# # Note: Actual UUID objects are tested in negative test cases (base.py)
373-
# UUID_CASE: Case = Case(
374-
# name="uuid",
375-
# data={"uuid_key": str(FIXED_UUID)},
376-
# json='{"uuid_key": "12345678-1234-5678-1234-567812345678"}',
377-
# )
378-
379-
# # Base64-encoded string case (tests string handling, not bytes object handling)
380-
# # Note: Actual bytes objects are tested in negative test cases (base.py)
381-
# BYTES_VALUE = b"hello world"
382-
# BYTES_CASE: Case = Case(
383-
# name="bytes",
384-
# data={"bytes_key": base64.b64encode(BYTES_VALUE).decode("ascii")},
385-
# json=f'{{"bytes_key": "{base64.b64encode(BYTES_VALUE).decode("ascii")}"}}',
386-
# )
387-
388-
# # List case (tests list handling, not tuple object handling)
389-
# # Note: Actual tuple objects are tested in negative test cases (base.py)
390-
# TUPLE_CASE: Case = Case(
391-
# name="tuple",
392-
# data={"tuple_key": [1, "two", 3.0]},
393-
# json='{"tuple_key": [1, "two", 3.0]}',
394-
# )
395-
396-
# # List case (tests list handling, not set object handling)
397-
# # Note: Actual set objects are tested in negative test cases (base.py)
398-
# SET_CASE: Case = Case(
399-
# name="set",
400-
# data={"set_key": {1, 2, 3}},
401-
# json='{"set_key": [1, 2, 3]}',
402-
# )
403-
404-
# # Deeply nested structure cases
405-
# DEEP_NESTED_CASE: Case = Case(
406-
# name="deep-nested",
407-
# data={"level1": {"level2": {"level3": {"level4": {"value": "deep"}}}}},
408-
# json='{"level1": {"level2": {"level3": {"level4": {"value": "deep"}}}}}',
409-
# )
410-
411-
# NESTED_LIST_DICT_CASE: Case = Case(
412-
# name="nested-list-dict",
413-
# data={"items": [{"id": 1, "name": "item1"}, {"id": 2, "name": "item2"}]},
414-
# json='{"items": [{"id": 1, "name": "item1"}, {"id": 2, "name": "item2"}]}',
415-
# )
416-
417-
# NESTED_DICT_LIST_CASE: Case = Case(
418-
# name="nested-dict-list",
419-
# data={"categories": {"fruits": ["apple", "banana"], "vegetables": ["carrot", "broccoli"]}},
420-
# json='{"categories": {"fruits": ["apple", "banana"], "vegetables": ["carrot", "broccoli"]}}',
421-
# )
422-
423-
# MIXED_NESTED_CASE: Case = Case(
424-
# name="mixed-nested",
425-
# data={"outer": {"inner": [{"nested": [1, 2, 3]}]}},
426-
# json='{"outer": {"inner": [{"nested": [1, 2, 3]}]}}',
427-
# )
428-
429-
# # Edge cases
430-
# EMPTY_STRING_CASE: Case = Case(
431-
# name="empty-string",
432-
# data={"empty_key": ""},
433-
# json='{"empty_key": ""}',
434-
# )
435-
436-
# EMPTY_LIST_CASE: Case = Case(
437-
# name="empty-list",
438-
# data={"empty_list_key": []},
439-
# json='{"empty_list_key": []}',
440-
# )
441-
442-
# EMPTY_DICT_CASE: Case = Case(
443-
# name="empty-dict",
444-
# data={"empty_dict_key": {}},
445-
# json='{"empty_dict_key": {}}',
446-
# )
447-
448-
# UNICODE_CASE: Case = Case(
449-
# name="unicode",
450-
# data={"unicode_key": "Hello 世界 🌍 émojis"},
451-
# json='{"unicode_key": "Hello \\u4e16\\u754c \\ud83c\\udf0d \\u00e9mojis"}',
452-
# )
453-
454-
# SPECIAL_CHARS_CASE: Case = Case(
455-
# name="special-chars",
456-
# data={"special_key": "Line1\nLine2\tTabbed"},
457-
# json='{"special_key": "Line1\\nLine2\\tTabbed"}',
458-
# )
459-
460-
# # Zero values
461-
# ZERO_INT_CASE: Case = Case(
462-
# name="zero-int",
463-
# data={"zero_int_key": 0},
464-
# json='{"zero_int_key": 0}',
465-
# )
466-
467-
# ZERO_FLOAT_CASE: Case = Case(
468-
# name="zero-float",
469-
# data={"zero_float_key": 0.0},
470-
# json='{"zero_float_key": 0.0}',
471-
# )
472-
473-
# NEGATIVE_INT_CASE: Case = Case(
474-
# name="negative-int",
475-
# data={"negative_int_key": -42},
476-
# json='{"negative_int_key": -42}',
477-
# )
478-
479-
# NEGATIVE_FLOAT_CASE: Case = Case(
480-
# name="negative-float",
481-
# data={"negative_float_key": -3.14},
482-
# json='{"negative_float_key": -3.14}',
483-
# )
484-
485-
# # Large collection case
486-
# LARGE_LIST_CASE: Case = Case(
487-
# name="large-list",
488-
# data={"large_list": list(range(1000))},
489-
# json=f'{{"large_list": {json.dumps(list(range(1000)))}}}',
490-
# )
491-
492-
493-
# TEST_CASE_DATA: list[dict[str, Any]] = [
494-
# case.data
495-
# for case in [
496-
# NULL_CASE,
497-
# BOOL_TRUE_CASE,
498-
# BOOL_FALSE_CASE,
499-
# INT_CASE,
500-
# LARGE_INT_CASE,
501-
# FLOAT_CASE,
502-
# LARGE_FLOAT_CASE,
503-
# STRING_CASE,
504-
# DICT_CASE_ONE,
505-
# DICT_CASE_TWO,
506-
# DICT_CASE_THREE,
507-
# LIST_CASE_ONE,
508-
# LIST_CASE_TWO,
509-
# LIST_CASE_THREE,
510-
# DATETIME_CASE,
511-
# DATE_CASE,
512-
# TIME_CASE,
513-
# UUID_CASE,
514-
# BYTES_CASE,
515-
# TUPLE_CASE,
516-
# SET_CASE,
517-
# DEEP_NESTED_CASE,
518-
# NESTED_LIST_DICT_CASE,
519-
# NESTED_DICT_LIST_CASE,
520-
# MIXED_NESTED_CASE,
521-
# EMPTY_STRING_CASE,
522-
# EMPTY_LIST_CASE,
523-
# EMPTY_DICT_CASE,
524-
# UNICODE_CASE,
525-
# SPECIAL_CHARS_CASE,
526-
# ZERO_INT_CASE,
527-
# ZERO_FLOAT_CASE,
528-
# NEGATIVE_INT_CASE,
529-
# NEGATIVE_FLOAT_CASE,
530-
# ]
531-
# ]
532-
# TEST_CASE_JSON: list[str] = [
533-
# case.json
534-
# for case in [
535-
# NULL_CASE,
536-
# BOOL_TRUE_CASE,
537-
# BOOL_FALSE_CASE,
538-
# INT_CASE,
539-
# LARGE_INT_CASE,
540-
# FLOAT_CASE,
541-
# LARGE_FLOAT_CASE,
542-
# STRING_CASE,
543-
# DICT_CASE_ONE,
544-
# DICT_CASE_TWO,
545-
# DICT_CASE_THREE,
546-
# LIST_CASE_ONE,
547-
# LIST_CASE_TWO,
548-
# LIST_CASE_THREE,
549-
# DATETIME_CASE,
550-
# DATE_CASE,
551-
# TIME_CASE,
552-
# UUID_CASE,
553-
# BYTES_CASE,
554-
# TUPLE_CASE,
555-
# SET_CASE,
556-
# DEEP_NESTED_CASE,
557-
# NESTED_LIST_DICT_CASE,
558-
# NESTED_DICT_LIST_CASE,
559-
# MIXED_NESTED_CASE,
560-
# EMPTY_STRING_CASE,
561-
# EMPTY_LIST_CASE,
562-
# EMPTY_DICT_CASE,
563-
# UNICODE_CASE,
564-
# SPECIAL_CHARS_CASE,
565-
# ZERO_INT_CASE,
566-
# ZERO_FLOAT_CASE,
567-
# NEGATIVE_INT_CASE,
568-
# NEGATIVE_FLOAT_CASE,
569-
# ]
570-
# ]
571-
572-
# SIMPLE_TEST_DATA_ARGNAMES: tuple[str, str] = ("data", "json")
573-
# SIMPLE_TEST_DATA_ARGVALUES: list[tuple[dict[str, Any], str]] = list(zip(TEST_CASE_DATA, TEST_CASE_JSON, strict=True))
574-
# SIMPLE_TEST_DATA_IDS: list[str] = [
575-
# case.name
576-
# for case in [
577-
# NULL_CASE,
578-
# BOOL_TRUE_CASE,
579-
# BOOL_FALSE_CASE,
580-
# INT_CASE,
581-
# LARGE_INT_CASE,
582-
# FLOAT_CASE,
583-
# LARGE_FLOAT_CASE,
584-
# STRING_CASE,
585-
# DICT_CASE_ONE,
586-
# DICT_CASE_TWO,
587-
# DICT_CASE_THREE,
588-
# LIST_CASE_ONE,
589-
# LIST_CASE_TWO,
590-
# LIST_CASE_THREE,
591-
# DATETIME_CASE,
592-
# DATE_CASE,
593-
# TIME_CASE,
594-
# UUID_CASE,
595-
# BYTES_CASE,
596-
# TUPLE_CASE,
597-
# SET_CASE,
598-
# DEEP_NESTED_CASE,
599-
# NESTED_LIST_DICT_CASE,
600-
# NESTED_DICT_LIST_CASE,
601-
# MIXED_NESTED_CASE,
602-
# EMPTY_STRING_CASE,
603-
# EMPTY_LIST_CASE,
604-
# EMPTY_DICT_CASE,
605-
# UNICODE_CASE,
606-
# SPECIAL_CHARS_CASE,
607-
# ZERO_INT_CASE,
608-
# ZERO_FLOAT_CASE,
609-
# NEGATIVE_INT_CASE,
610-
# NEGATIVE_FLOAT_CASE,
611-
# ]
612-
# ]
613-
614-
# LARGE_TEST_DATA_DATA: list[dict[str, Any]] = [
615-
# case.data
616-
# for case in [
617-
# LARGE_STRING_CASE,
618-
# LARGE_INT_CASE,
619-
# LARGE_FLOAT_CASE,
620-
# LARGE_LIST_CASE,
621-
# ]
622-
# ]
623-
# LARGE_TEST_DATA_JSON: list[str] = [
624-
# case.json
625-
# for case in [
626-
# LARGE_STRING_CASE,
627-
# LARGE_INT_CASE,
628-
# LARGE_FLOAT_CASE,
629-
# LARGE_LIST_CASE,
630-
# ]
631-
# ]
632-
# LARGE_TEST_DATA_ARGNAMES: tuple[str, str] = ("data", "json")
633-
# LARGE_TEST_DATA_ARGVALUES: list[tuple[dict[str, Any], str]] = list(zip(LARGE_TEST_DATA_DATA, LARGE_TEST_DATA_JSON, strict=True))
634-
# LARGE_TEST_DATA_IDS: list[str] = [
635-
# case.name
636-
# for case in [
637-
# LARGE_STRING_CASE,
638-
# LARGE_INT_CASE,
639-
# LARGE_FLOAT_CASE,
640-
# LARGE_LIST_CASE,
641-
# ]
642-
# ]
643-
644-
# NEGATIVE_TEST_DATA_DATA: list[dict[str, Any]] = [
645-
# case.data
646-
# for case in [
647-
# DATETIME_CASE,
648-
# DATE_CASE,
649-
# TIME_CASE,
650-
# UUID_CASE,
651-
# ]
652-
# ]
653-
654-
# NEGATIVE_TEST_DATA_JSON: list[str] = [
655-
# case.json
656-
# for case in [
657-
# DATETIME_CASE,
658-
# DATE_CASE,
659-
# TIME_CASE,
660-
# UUID_CASE,
661-
# ]
662-
# ]
663-
# NEGATIVE_TEST_DATA_ARGNAMES: tuple[str, str] = ("data", "json")
664-
# NEGATIVE_TEST_DATA_ARGVALUES: list[tuple[dict[str, Any], str]] = list(zip(NEGATIVE_TEST_DATA_DATA, NEGATIVE_TEST_DATA_JSON, strict=True))
665-
# NEGATIVE_TEST_DATA_IDS: list[str] = [
666-
# case.name
667-
# for case in [
668-
# DATETIME_CASE,
669-
# DATE_CASE,
670-
# TIME_CASE,
671-
# UUID_CASE,
672-
# ]
673-
# ]
674-
675-
# __all__ = [
676-
# "LARGE_TEST_DATA_ARGNAMES",
677-
# "LARGE_TEST_DATA_ARGVALUES",
678-
# "LARGE_TEST_DATA_IDS",
679-
# "SIMPLE_TEST_DATA_ARGNAMES",
680-
# "SIMPLE_TEST_DATA_ARGVALUES",
681-
# "SIMPLE_TEST_DATA_IDS",
682-
# ]

0 commit comments

Comments
 (0)