feat: add version testing for all distributed stores (#125)

Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Co-authored-by: William Easton <[email protected]>

Author: strawgate

key-value/key-value-aio/pyproject.toml

@@ -56,6 +56,7 @@ addopts = [
     "--inline-snapshot=disable",
     "-n=auto",
     "--dist=loadfile",
+    "--maxfail=5"
 ]
 markers = [
     "skip_on_ci: Skip running the test when running on CI",

key-value/key-value-aio/src/key_value/aio/stores/elasticsearch/store.py

@@ -1,5 +1,7 @@
-from typing import TYPE_CHECKING, Any, overload
+from datetime import datetime  # noqa: TC003
+from typing import Any, overload
 
+from elastic_transport import ObjectApiResponse  # noqa: TC002
 from key_value.shared.utils.compound import compound_key
 from key_value.shared.utils.managed_entry import ManagedEntry, load_from_json
 from key_value.shared.utils.sanitize import (
@@ -33,10 +35,6 @@
     msg = "ElasticsearchStore requires py-key-value-aio[elasticsearch]"
     raise ImportError(msg) from e
 
-if TYPE_CHECKING:
-    from datetime import datetime
-
-    from elastic_transport import ObjectApiResponse
 
 DEFAULT_INDEX_PREFIX = "kv_store"
 

key-value/key-value-aio/tests/conftest.py

@@ -33,7 +33,7 @@ def get_docker_client() -> DockerClient:
     return DockerClient.from_env()
 
 
-@pytest.fixture(scope="session")
+@pytest.fixture
 def docker_client() -> DockerClient:
     return get_docker_client()
 

key-value/key-value-aio/tests/stores/dynamodb/test_dynamodb.py

@@ -18,6 +18,13 @@
 
 WAIT_FOR_DYNAMODB_TIMEOUT = 30
 
+DYNAMODB_VERSIONS_TO_TEST = [
+    "2.0.0",  # Released Jul 2023
+    "3.1.0",  # Released Sep 2025
+]
+
+DYNAMODB_CONTAINER_PORT = 8000
+
 
 async def ping_dynamodb() -> bool:
     """Check if DynamoDB Local is running."""
@@ -43,16 +50,18 @@ class DynamoDBFailedToStartError(Exception):
 
 @pytest.mark.skipif(should_skip_docker_tests(), reason="Docker is not available")
 class TestDynamoDBStore(ContextManagerStoreTestMixin, BaseStoreTests):
-    @pytest.fixture(autouse=True, scope="session")
-    async def setup_dynamodb(self) -> AsyncGenerator[None, None]:
+    @pytest.fixture(autouse=True, scope="session", params=DYNAMODB_VERSIONS_TO_TEST)
+    async def setup_dynamodb(self, request: pytest.FixtureRequest) -> AsyncGenerator[None, None]:
+        version = request.param
+
         # DynamoDB Local container
         with docker_container(
-            "dynamodb-test",
-            "amazon/dynamodb-local:latest",
-            {"8000": DYNAMODB_HOST_PORT},
+            f"dynamodb-test-{version}",
+            f"amazon/dynamodb-local:{version}",
+            {str(DYNAMODB_CONTAINER_PORT): DYNAMODB_HOST_PORT},
         ):
-            if not await async_wait_for_true(bool_fn=ping_dynamodb, tries=30, wait_time=1):
-                msg = "DynamoDB failed to start"
+            if not await async_wait_for_true(bool_fn=ping_dynamodb, tries=WAIT_FOR_DYNAMODB_TIMEOUT, wait_time=1):
+                msg = f"DynamoDB {version} failed to start"
                 raise DynamoDBFailedToStartError(msg)
 
             yield

key-value/key-value-aio/tests/stores/elasticsearch/test_elasticsearch.py

@@ -1,4 +1,3 @@
-import os
 from collections.abc import AsyncGenerator
 
 import pytest
@@ -8,15 +7,21 @@
 
 from key_value.aio.stores.base import BaseStore
 from key_value.aio.stores.elasticsearch import ElasticsearchStore
-from tests.conftest import docker_container
+from tests.conftest import docker_container, should_skip_docker_tests
 from tests.stores.base import BaseStoreTests, ContextManagerStoreTestMixin
 
 TEST_SIZE_LIMIT = 1 * 1024 * 1024  # 1MB
 ES_HOST = "localhost"
 ES_PORT = 9200
 ES_URL = f"http://{ES_HOST}:{ES_PORT}"
-ES_VERSION = "9.1.4"
-ES_IMAGE = f"docker.elastic.co/elasticsearch/elasticsearch:{ES_VERSION}"
+ES_CONTAINER_PORT = 9200
+
+WAIT_FOR_ELASTICSEARCH_TIMEOUT = 30
+
+ELASTICSEARCH_VERSIONS_TO_TEST = [
+    "9.0.0",  # Released Apr 2025
+    "9.2.0",  # Released Oct 2025
+]
 
 
 def get_elasticsearch_client() -> AsyncElasticsearch:
@@ -34,15 +39,21 @@ class ElasticsearchFailedToStartError(Exception):
     pass
 
 
-@pytest.mark.skipif(os.getenv("ES_URL") is None, reason="Elasticsearch is not configured")
+@pytest.mark.skipif(should_skip_docker_tests(), reason="Docker is not running")
 class TestElasticsearchStore(ContextManagerStoreTestMixin, BaseStoreTests):
-    @pytest.fixture(autouse=True, scope="session")
-    async def setup_elasticsearch(self) -> AsyncGenerator[None, None]:
+    @pytest.fixture(autouse=True, scope="session", params=ELASTICSEARCH_VERSIONS_TO_TEST)
+    async def setup_elasticsearch(self, request: pytest.FixtureRequest) -> AsyncGenerator[None, None]:
+        version = request.param
+        es_image = f"docker.elastic.co/elasticsearch/elasticsearch:{version}"
+
         with docker_container(
-            "elasticsearch-test", ES_IMAGE, {"9200": ES_PORT}, {"discovery.type": "single-node", "xpack.security.enabled": "false"}
+            f"elasticsearch-test-{version}",
+            es_image,
+            {str(ES_CONTAINER_PORT): ES_PORT},
+            {"discovery.type": "single-node", "xpack.security.enabled": "false"},
         ):
-            if not await async_wait_for_true(bool_fn=ping_elasticsearch, tries=30, wait_time=2):
-                msg = "Elasticsearch failed to start"
+            if not await async_wait_for_true(bool_fn=ping_elasticsearch, tries=WAIT_FOR_ELASTICSEARCH_TIMEOUT, wait_time=2):
+                msg = f"Elasticsearch {version} failed to start"
                 raise ElasticsearchFailedToStartError(msg)
 
             yield
@@ -55,10 +66,10 @@ async def es_client(self) -> AsyncGenerator[AsyncElasticsearch, None]:
     @override
     @pytest.fixture
     async def store(self) -> AsyncGenerator[ElasticsearchStore, None]:
-        es_client = get_elasticsearch_client()
-        indices = await es_client.options(ignore_status=404).indices.get(index="kv-store-e2e-test-*")
-        for index in indices:
-            _ = await es_client.options(ignore_status=404).indices.delete(index=index)
+        async with get_elasticsearch_client() as es_client:
+            indices = await es_client.options(ignore_status=404).indices.get(index="kv-store-e2e-test-*")
+            for index in indices:
+                _ = await es_client.options(ignore_status=404).indices.delete(index=index)
         async with ElasticsearchStore(url=ES_URL, index_prefix="kv-store-e2e-test") as store:
             yield store
 

key-value/key-value-aio/tests/stores/memcached/test_memcached.py

@@ -14,10 +14,15 @@
 # Memcached test configuration
 MEMCACHED_HOST = "localhost"
 MEMCACHED_PORT = 11211
-MEMCACHED_IMAGE = "memcached:1.6"
+MEMCACHED_CONTAINER_PORT = 11211
 
 WAIT_FOR_MEMCACHED_TIMEOUT = 30
 
+MEMCACHED_VERSIONS_TO_TEST = [
+    "1.6.0-alpine",  # Released Mar 2020
+    "1.6.39-alpine",  # Released Sep 2025
+]
+
 
 async def ping_memcached() -> bool:
     client = Client(host=MEMCACHED_HOST, port=MEMCACHED_PORT)
@@ -38,18 +43,20 @@ class MemcachedFailedToStartError(Exception):
 
 @pytest.mark.skipif(should_skip_docker_tests(), reason="Docker is not available")
 class TestMemcachedStore(ContextManagerStoreTestMixin, BaseStoreTests):
-    @pytest.fixture(autouse=True, scope="session")
-    async def setup_memcached(self) -> AsyncGenerator[None, None]:
-        with docker_container("memcached-test", MEMCACHED_IMAGE, {"11211": MEMCACHED_PORT}):
-            if not await async_wait_for_true(bool_fn=ping_memcached, tries=30, wait_time=1):
-                msg = "Memcached failed to start"
+    @pytest.fixture(autouse=True, scope="session", params=MEMCACHED_VERSIONS_TO_TEST)
+    async def setup_memcached(self, request: pytest.FixtureRequest) -> AsyncGenerator[None, None]:
+        version = request.param
+
+        with docker_container(f"memcached-test-{version}", f"memcached:{version}", {str(MEMCACHED_CONTAINER_PORT): MEMCACHED_PORT}):
+            if not await async_wait_for_true(bool_fn=ping_memcached, tries=WAIT_FOR_MEMCACHED_TIMEOUT, wait_time=1):
+                msg = f"Memcached {version} failed to start"
                 raise MemcachedFailedToStartError(msg)
 
             yield
 
     @override
     @pytest.fixture
-    async def store(self, setup_memcached: MemcachedStore) -> MemcachedStore:
+    async def store(self, setup_memcached: None) -> MemcachedStore:
         store = MemcachedStore(host=MEMCACHED_HOST, port=MEMCACHED_PORT)
         _ = await store._client.flush_all()  # pyright: ignore[reportPrivateUsage]
         return store

key-value/key-value-aio/tests/stores/mongodb/test_mongodb.py

@@ -20,6 +20,11 @@
 
 WAIT_FOR_MONGODB_TIMEOUT = 30
 
+MONGODB_VERSIONS_TO_TEST = [
+    "5.0",  # Older supported version
+    "8.0",  # Latest stable version
+]
+
 
 async def ping_mongodb() -> bool:
     try:
@@ -37,11 +42,13 @@ class MongoDBFailedToStartError(Exception):
 
 @pytest.mark.skipif(should_skip_docker_tests(), reason="Docker is not available")
 class TestMongoDBStore(ContextManagerStoreTestMixin, BaseStoreTests):
-    @pytest.fixture(autouse=True, scope="session")
-    async def setup_mongodb(self) -> AsyncGenerator[None, None]:
-        with docker_container("mongodb-test", "mongo:7", {"27017": 27017}):
-            if not await async_wait_for_true(bool_fn=ping_mongodb, tries=30, wait_time=1):
-                msg = "MongoDB failed to start"
+    @pytest.fixture(autouse=True, scope="session", params=MONGODB_VERSIONS_TO_TEST)
+    async def setup_mongodb(self, request: pytest.FixtureRequest) -> AsyncGenerator[None, None]:
+        version = request.param
+
+        with docker_container(f"mongodb-test-{version}", f"mongo:{version}", {str(MONGODB_HOST_PORT): MONGODB_HOST_PORT}):
+            if not await async_wait_for_true(bool_fn=ping_mongodb, tries=WAIT_FOR_MONGODB_TIMEOUT, wait_time=1):
+                msg = f"MongoDB {version} failed to start"
                 raise MongoDBFailedToStartError(msg)
 
             yield

key-value/key-value-aio/tests/stores/valkey/test_valkey.py

@@ -1,3 +1,4 @@
+import contextlib
 from collections.abc import AsyncGenerator
 
 import pytest
@@ -15,9 +16,16 @@
 VALKEY_HOST = "localhost"
 VALKEY_PORT = 6380  # normally 6379, avoid clashing with Redis tests
 VALKEY_DB = 15
+VALKEY_CONTAINER_PORT = 6379
 
 WAIT_FOR_VALKEY_TIMEOUT = 30
 
+VALKEY_VERSIONS_TO_TEST = [
+    "7.2.5",  # Released Apr 2024
+    "8.0.0",  # Released Sep 2024
+    "9.0.0",  # Released Oct 2025
+]
+
 
 class ValkeyFailedToStartError(Exception):
     pass
@@ -36,19 +44,26 @@ async def get_valkey_client(self):
         return await GlideClient.create(config=client_config)
 
     async def ping_valkey(self) -> bool:
+        client = None
         try:
             client = await self.get_valkey_client()
-            _ = await client.ping()
+            await client.ping()
         except Exception:
             return False
-
-        return True
-
-    @pytest.fixture(scope="session")
-    async def setup_valkey(self) -> AsyncGenerator[None, None]:
-        with docker_container("valkey-test", "valkey/valkey:latest", {"6379": VALKEY_PORT}):
-            if not await async_wait_for_true(bool_fn=self.ping_valkey, tries=30, wait_time=1):
-                msg = "Valkey failed to start"
+        else:
+            return True
+        finally:
+            if client is not None:
+                with contextlib.suppress(Exception):
+                    await client.close()
+
+    @pytest.fixture(scope="session", params=VALKEY_VERSIONS_TO_TEST)
+    async def setup_valkey(self, request: pytest.FixtureRequest) -> AsyncGenerator[None, None]:
+        version = request.param
+
+        with docker_container(f"valkey-test-{version}", f"valkey/valkey:{version}", {str(VALKEY_CONTAINER_PORT): VALKEY_PORT}):
+            if not await async_wait_for_true(bool_fn=self.ping_valkey, tries=WAIT_FOR_VALKEY_TIMEOUT, wait_time=1):
+                msg = f"Valkey {version} failed to start"
                 raise ValkeyFailedToStartError(msg)
 
             yield

key-value/key-value-aio/tests/stores/vault/test_vault.py

@@ -15,6 +15,14 @@
 VAULT_PORT = 8200
 VAULT_TOKEN = "dev-root-token"  # noqa: S105
 VAULT_MOUNT_POINT = "secret"
+VAULT_CONTAINER_PORT = 8200
+
+WAIT_FOR_VAULT_TIMEOUT = 30
+
+VAULT_VERSIONS_TO_TEST = [
+    "1.12.0",  # Released Oct 2022
+    "1.21.0",  # Released Oct 2025
+]
 
 
 class VaultFailedToStartError(Exception):
@@ -23,31 +31,33 @@ class VaultFailedToStartError(Exception):
 
 @pytest.mark.skipif(should_skip_docker_tests(), reason="Docker is not running")
 class TestVaultStore(BaseStoreTests):
-    async def get_vault_client(self):
+    def get_vault_client(self):
         import hvac
 
         return hvac.Client(url=f"http://{VAULT_HOST}:{VAULT_PORT}", token=VAULT_TOKEN)
 
     async def ping_vault(self) -> bool:
         try:
-            client = await self.get_vault_client()
+            client = self.get_vault_client()
             return client.sys.is_initialized()  # pyright: ignore[reportUnknownMemberType,reportUnknownReturnType,reportUnknownVariableType]
         except Exception:
             return False
 
-    @pytest.fixture(scope="session")
-    async def setup_vault(self) -> AsyncGenerator[None, None]:
+    @pytest.fixture(scope="session", params=VAULT_VERSIONS_TO_TEST)
+    async def setup_vault(self, request: pytest.FixtureRequest) -> AsyncGenerator[None, None]:
+        version = request.param
+
         with docker_container(
-            "vault-test",
-            "hashicorp/vault:latest",
-            {"8200": VAULT_PORT},
+            f"vault-test-{version}",
+            f"hashicorp/vault:{version}",
+            {str(VAULT_CONTAINER_PORT): VAULT_PORT},
             environment={
                 "VAULT_DEV_ROOT_TOKEN_ID": VAULT_TOKEN,
                 "VAULT_DEV_LISTEN_ADDRESS": "0.0.0.0:8200",
             },
         ):
-            if not await async_wait_for_true(bool_fn=self.ping_vault, tries=30, wait_time=1):
-                msg = "Vault failed to start"
+            if not await async_wait_for_true(bool_fn=self.ping_vault, tries=WAIT_FOR_VAULT_TIMEOUT, wait_time=1):
+                msg = f"Vault {version} failed to start"
                 raise VaultFailedToStartError(msg)
 
             yield
@@ -64,7 +74,7 @@ async def store(self, setup_vault: None):
         )
 
         # Clean up any existing data - best effort, ignore errors
-        client = await self.get_vault_client()
+        client = self.get_vault_client()
         try:
             # List all secrets and delete them
             secrets_list = client.secrets.kv.v2.list_secrets(path="", mount_point=VAULT_MOUNT_POINT)  # pyright: ignore[reportUnknownMemberType,reportUnknownReturnType,reportUnknownVariableType]

key-value/key-value-sync/pyproject.toml

@@ -55,6 +55,7 @@ addopts = [
     "--inline-snapshot=disable",
     "-n=auto",
     "--dist=loadfile",
+    "--maxfail=5"
 ]
 markers = [
     "skip_on_ci: Skip running the test when running on CI",