Skip to content

Commit 5d41ae7

Browse files
committed
small pr updates
1 parent e648e68 commit 5d41ae7

File tree

4 files changed

+4
-36
lines changed

4 files changed

+4
-36
lines changed

key-value/key-value-aio/src/key_value/aio/stores/memory/store.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ def __init__(
111111
Seeding occurs lazily when each collection is first accessed.
112112
"""
113113

114-
self.max_entries_per_collection = max_entries_per_collection or sys.maxsize
114+
self.max_entries_per_collection = max_entries_per_collection if max_entries_per_collection is not None else sys.maxsize
115115

116116
self._cache = {}
117117

key-value/key-value-aio/src/key_value/aio/stores/simple/store.py

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,8 @@
44
from datetime import datetime
55

66
from key_value.shared.utils.compound import compound_key, get_collections_from_compound_keys, get_keys_from_compound_keys
7-
from key_value.shared.utils.managed_entry import ManagedEntry, load_from_json
7+
from key_value.shared.utils.managed_entry import ManagedEntry
88
from key_value.shared.utils.serialization import BasicSerializationAdapter
9-
from key_value.shared.utils.time_to_live import seconds_to
109
from typing_extensions import override
1110

1211
from key_value.aio.stores.base import (
@@ -26,22 +25,6 @@ class SimpleStoreEntry:
2625
created_at: datetime | None
2726
expires_at: datetime | None
2827

29-
@property
30-
def current_ttl(self) -> float | None:
31-
if self.expires_at is None:
32-
return None
33-
34-
return seconds_to(datetime=self.expires_at)
35-
36-
def to_managed_entry(self) -> ManagedEntry:
37-
managed_entry: ManagedEntry = ManagedEntry(
38-
value=load_from_json(json_str=self.json_str),
39-
expires_at=self.expires_at,
40-
created_at=self.created_at,
41-
)
42-
43-
return managed_entry
44-
4528

4629
class SimpleStore(BaseEnumerateCollectionsStore, BaseEnumerateKeysStore, BaseDestroyStore, BaseStore):
4730
"""Simple managed dictionary-based key-value store for testing and development."""

key-value/key-value-sync/src/key_value/sync/code_gen/stores/memory/store.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ def __init__(
108108
Seeding occurs lazily when each collection is first accessed.
109109
"""
110110

111-
self.max_entries_per_collection = max_entries_per_collection or sys.maxsize
111+
self.max_entries_per_collection = max_entries_per_collection if max_entries_per_collection is not None else sys.maxsize
112112

113113
self._cache = {}
114114

key-value/key-value-sync/src/key_value/sync/code_gen/stores/simple/store.py

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,8 @@
77
from datetime import datetime
88

99
from key_value.shared.utils.compound import compound_key, get_collections_from_compound_keys, get_keys_from_compound_keys
10-
from key_value.shared.utils.managed_entry import ManagedEntry, load_from_json
10+
from key_value.shared.utils.managed_entry import ManagedEntry
1111
from key_value.shared.utils.serialization import BasicSerializationAdapter
12-
from key_value.shared.utils.time_to_live import seconds_to
1312
from typing_extensions import override
1413

1514
from key_value.sync.code_gen.stores.base import BaseDestroyStore, BaseEnumerateCollectionsStore, BaseEnumerateKeysStore, BaseStore
@@ -24,20 +23,6 @@ class SimpleStoreEntry:
2423
created_at: datetime | None
2524
expires_at: datetime | None
2625

27-
@property
28-
def current_ttl(self) -> float | None:
29-
if self.expires_at is None:
30-
return None
31-
32-
return seconds_to(datetime=self.expires_at)
33-
34-
def to_managed_entry(self) -> ManagedEntry:
35-
managed_entry: ManagedEntry = ManagedEntry(
36-
value=load_from_json(json_str=self.json_str), expires_at=self.expires_at, created_at=self.created_at
37-
)
38-
39-
return managed_entry
40-
4126

4227
class SimpleStore(BaseEnumerateCollectionsStore, BaseEnumerateKeysStore, BaseDestroyStore, BaseStore):
4328
"""Simple managed dictionary-based key-value store for testing and development."""

0 commit comments

Comments
 (0)