This repository was archived by the owner on Jul 13, 2023. It is now read-only.
feat: Add transform dereference result hook #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marbemac
suggested changes
Jul 26, 2019
src/runner.ts
Outdated
| const parsed = await this.parseResolveResult({ | ||
| uriResult: result, | ||
| // TODO: Is this correct? Result has type any, but uriResult should be type IUriResult. | ||
| // uriResult: result, |
There was a problem hiding this comment.
uriResult here is a just an object, but according to types.ts, it should be IUriResult.
result comes from this line
There was a problem hiding this comment.
I undid my changes, but we should at the very least update types.ts probably.
src/runner.ts
Outdated
| fragment: ref.fragment(), | ||
| }); | ||
| if (error) { | ||
| throw new Error(`Could not transform dereferenced result for '${ref.toString()}' - ${String(error)}`); |
There was a problem hiding this comment.
Perhaps could set lookupResult.error rather than throw?
There was a problem hiding this comment.
Let me know what you think now after moving where this get's called at.
src/types.ts
Outdated
| result: any; | ||
| fragment: string; | ||
| uriResult: IUriResult; | ||
| // uriResult: IUriResult; |
marbemac
reviewed
Jul 29, 2019
marbemac
approved these changes
Jul 30, 2019
|
🎉 This PR is included in version 2.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.