Skip to content

Typo in method name and inconsistance between traits #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pythcoiner opened this issue Feb 14, 2024 · 0 comments
Open

Typo in method name and inconsistance between traits #360

pythcoiner opened this issue Feb 14, 2024 · 0 comments

Comments

@pythcoiner
Copy link

Typo in configure_intter(r)upt()
_____________________ ^ __ ^

fn configure_intterupt(&mut self, event: Event, enable: bool) {

Also signatures are non consistent between dma::Channel and serial::Serial:

pub fn configure_interrupt(&mut self, event: Event, enable: impl Into<Switch>) {

I can PR if you think it worth a breaking change on dma::Channel ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant