CocoaPods: build standalone version of SQLite with subspec #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jberkel
changed the title
|
Nice! This looks good, but I wonder if we can somehow retain the |
The standard subspec is the default and behaves as previously; the standalone subspec adds a dependency to the sqlite3 pod which downloads and compiles a version of SQLite instead of using the system-supplied version. The version of SQLite used can be further customized by requiring another sqlite3 subspec from the main Podfile.
|
Ah, I wondered about the weird naming, now it makes sense. I changed it so that the renaming is avoided, it also makes it clearer which module is being used. |
|
Beautiful, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adresses #401.
Not sure about the "standalone" spec name – I just followed the pattern used in https://github.com/ccgus/fmdb/blob/master/FMDB.podspec.
Passes
pod spec lint --allow-warnings.The existing behavior and setup is left unchanged. I can't think of a good way to integrate the SQLite sources in a submodule, maybe this could be addressed in a separate PR.
It also needs tests – maybe a dummy project could be set up automatically, including test suite.