Fix patch order for interdependent move operations #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When
jsonpatch.make_patch()
creates patches with multiple interdependent move operations, the operations are sometimes ordered incorrectly, resulting in incorrect patch application. This happened because the order in which operations were generated didn't account for dependencies between operations.The issue occurs when:
If these operations are executed in the wrong order, they can produce incorrect results.
Solution
The solution implements a dependency analysis for move operations to ensure proper order:
DiffBuilder.execute()
This approach ensures that interdependent move operations are consistently ordered for proper execution.
Example of the issue (now fixed):
Fixes #160.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.