Skip to content

Full migrate to Angular 7 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Conversation

fabiomartino
Copy link
Contributor

This PR is a full migration to Angular v7.

  • Updated dependencies and dev dependencies
  • Removed deprecated
  • Fix instances of variables declarations (trivial)
  • Fix all 'ng lint' errors and warnings
  • Updated .vscode settings and recommended extensions (handy for debugging purpose)

Enjoy!

@rafaelsilvestri
Copy link

Hi Fabio, I was looking forward for this update. I'm curious what changes in flex-layout 7, I've an app based on this template and after I updated to angular 7 , by my own, the only thing broken was the flex-layout. I noticed the you changed from fxFlex to fxFlex="" in some places but it was not enough for me. Do you have details regarding update flex-layout to 7?

I hope this PR is accepted asap

@nkmdev nkmdev merged commit 9ed5faf into start-javascript:master Nov 22, 2018
@fabiomartino
Copy link
Contributor Author

fabiomartino commented Nov 22, 2018

Hi Fabio, I was looking forward for this update. I'm curious what changes in flex-layout 7, I've an app based on this template and after I updated to angular 7 , by my own, the only thing broken was the flex-layout. I noticed the you changed from fxFlex to fxFlex="" in some places but it was not enough for me. Do you have details regarding update flex-layout to 7?

I hope this PR is accepted asap

Hi.
I don't have much info...
I think this small config for your module can do the job...

FlexLayoutModule.withConfig({addFlexToParent: false})

but take a look at BREAKING CHANGES for version 6.0.0-beta16
https://github.com/angular/flex-layout/blob/master/CHANGELOG.md
where the four configurations tokens:

  • ADD_FLEX_STYLES
  • ADD_ORIENTATION_BREAKPOINTS
  • DISABLE_DEFAULT_BREAKPOINTS
  • DISABLE_VENDOR_PREFIXES
    have been replaced with:
  • LAYOUT_CONFIG

Also this issue
give you an idea about how fix it.
angular/flex-layout#778 (comment)

Cordially
Fabio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants