Skip to content

Commit d349968

Browse files
author
Sean Han
committed
chore: merge conflicts and small fixes
2 parents ebf07b4 + 4214294 commit d349968

File tree

12 files changed

+40
-298
lines changed

12 files changed

+40
-298
lines changed

.github/workflows/release.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ jobs:
3030
with:
3131
node-version: lts/*
3232
- run: npm ci
33-
- run: npm run docs
3433
- uses: actions/download-artifact@v2
3534
with:
3635
name: build

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,5 @@ dist
33
npm-debug.log
44
.env
55
.DS_Store
6+
docs
67
.eslintcache

.releaserc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
"@semantic-release/git",
1616
{
1717
"assets": [
18-
"docs/README.md",
1918
"package.json",
2019
"CHANGELOG.md"
2120
],

README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,10 @@ Install starknet with `npm`
4242
$ npm install starknet
4343
```
4444

45-
Import `starknet` and use the [API](docs)
45+
Import `starknet` and use the [API](https://www.starknetjs.com/modules.html)
4646

4747
```javascript
48-
import starknet from 'starknet';
48+
import * as starknet from 'starknet';
4949

5050
starknet.getContractAddresses().then((data) => {
5151
console.log(data);
@@ -54,14 +54,14 @@ starknet.getContractAddresses().then((data) => {
5454

5555
## 🌐 API
5656

57-
[Click Here](docs)
57+
[Click Here](https://www.starknetjs.com/modules.html)
5858

5959
## Contributing
6060

61-
If you consider to contribute to this project please read [CONTRIBUTING.md](CONTRIBUTING.md) first.
61+
If you consider to contribute to this project please read [CONTRIBUTING.md](https://github.com/seanjameshan/starknet.js/blob/main/CONTRIBUTING.md) first.
6262

6363
## License
6464

6565
Copyright (c) 2021 Sean James Han
6666

67-
Licensed under the [MIT license](LICENSE).
67+
Licensed under the [MIT license](https://github.com/seanjameshan/starknet.js/blob/main/LICENSE).

__tests__/contracts.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const compiledERC20: CompiledContract = JsonParser.parse(
1313
fs.readFileSync('./__mocks__/ERC20.json').toString('ascii')
1414
);
1515

16-
describe('new Contract()', () => {
16+
describe('class Contract {}', () => {
1717
const address = randomAddress();
1818
const wallet = randomAddress();
1919
const contract = new Contract(compiledERC20.abi, address);

docs/.nojekyll

Lines changed: 0 additions & 1 deletion
This file was deleted.

docs/README.md

Lines changed: 0 additions & 235 deletions
This file was deleted.

package-lock.json

Lines changed: 0 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"test": "jest",
1212
"posttest": "npm run format",
1313
"test:watch": "jest --watch",
14-
"docs": "typedoc --readme none --name 'StarkNet.js Docs' --excludeNotDocumented --disableSources",
14+
"docs": "typedoc",
1515
"format": "prettier --loglevel warn --write \"**/*.{ts,js,md,yml,json}\"",
1616
"lint": "eslint . --cache --fix --ext .ts"
1717
},
@@ -51,7 +51,6 @@
5151
"lint-staged": "^11.2.3",
5252
"prettier": "^2.4.1",
5353
"typedoc": "^0.22.6",
54-
"typedoc-plugin-markdown": "^3.11.3",
5554
"typescript": "^4.4.4"
5655
},
5756
"dependencies": {

src/starknet.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import axios from 'axios';
22
import { randomAddress, compressProgram, JsonParser } from './utils';
33
import type {
44
GetBlockResponse,
5-
GetCode,
5+
GetCodeResponse,
66
GetContractAddressesResponse,
77
GetTransactionResponse,
88
GetTransactionStatusResponse,
@@ -82,10 +82,10 @@ export function getBlock(blockId: number): Promise<GetBlockResponse> {
8282
* @param blockId
8383
* @returns Bytecode and ABI of compiled contract
8484
*/
85-
export function getCode(contractAddress: string, blockId: number): Promise<GetCode> {
85+
export function getCode(contractAddress: string, blockId: number): Promise<GetCodeResponse> {
8686
return new Promise((resolve, reject) => {
8787
axios
88-
.get<GetCode>(
88+
.get<GetCodeResponse>(
8989
`${FEEDER_GATEWAY_URL}/get_code?contractAddress=${contractAddress}&blockId=${blockId}`
9090
)
9191
.then((resp) => {

0 commit comments

Comments
 (0)