fix: use function consistently

Author: janek26

__tests__/ec.test.ts renamed to __tests__/ellipticalCurve.test.ts

@@ -1,5 +1,5 @@
 import { getKeyPair, getStarkKey, hashCalldata, hashMessage, pedersen, sign } from '../src';
-import { removeHexPrefix } from '../src/utils/enc';
+import { removeHexPrefix } from '../src/utils/encode';
 import { toBN, toHex } from '../src/utils/number';
 
 test('does work with package', () => {

__tests__/wallet.test.ts

@@ -11,7 +11,7 @@ import {
   utils,
   waitForTx,
 } from '../src';
-import { addHexPrefix } from '../src/utils/enc';
+import { addHexPrefix } from '../src/utils/encode';
 import { toBN } from '../src/utils/number';
 
 const {

src/constants.ts

@@ -1,6 +1,6 @@
 import { toBN } from './utils/number';
 
-export { IS_BROWSER } from './utils/enc';
+export { IS_BROWSER } from './utils/encode';
 
 export const ZERO = toBN(0);
 export const ONE = toBN(1);

src/contract.ts

@@ -9,22 +9,22 @@ import { getSelectorFromName } from './utils/starknet';
 type Args = { [inputName: string]: string | string[] };
 type Calldata = string[];
 
-const parseFelt = (candidate: string): BN => {
+function parseFelt(candidate: string): BN {
   try {
     return toBN(candidate);
   } catch (e) {
     throw Error('Couldnt parse felt');
   }
-};
+}
 
-const isFelt = (candidate: string): boolean => {
+function isFelt(candidate: string): boolean {
   try {
     parseFelt(candidate);
     return true;
   } catch (e) {
     return false;
   }
-};
+}
 
 export class Contract {
   connectedTo: string | null = null;

src/ec.ts renamed to src/ellipticalCurve.ts

@@ -3,7 +3,7 @@ import hashJS from 'hash.js';
 import assert from 'minimalistic-assert';
 
 import { CONSTANT_POINTS, EC_ORDER, FIELD_PRIME, MAX_ECDSA_VAL, ONE, ZERO } from './constants';
-import { addHexPrefix, removeHexPrefix, sanitizeBytes } from './utils/enc';
+import { addHexPrefix, removeHexPrefix, sanitizeBytes } from './utils/encode';
 import { BigNumberish, assertInRange, toBN, toHex } from './utils/number';
 
 export const ec = new EC(
@@ -40,17 +40,17 @@ function fixMessage(msg: string) {
 
 export const genKeyPair = ec.genKeyPair.bind(ec);
 
-export const getKeyPair = (pk: BigNumberish): EC.KeyPair => {
+export function getKeyPair(pk: BigNumberish): EC.KeyPair {
   const pkBn = toBN(pk);
   return ec.keyFromPrivate(removeHexPrefix(toHex(pkBn)), 'hex');
-};
+}
 
-export const getStarkKey = (keyPair: EC.KeyPair): string => {
+export function getStarkKey(keyPair: EC.KeyPair): string {
   // this method needs to be run to generate the .pub property used below
   // the result can be dumped
   keyPair.getPublic(true, 'hex');
   return addHexPrefix(sanitizeBytes((keyPair as any).pub.getX().toString(16), 2));
-};
+}
 
 /*
  Signs a message using the provided key.

src/starknet.ts

@@ -213,7 +213,9 @@ export function deployContract(
   });
 }
 
-const wait = (delay: number) => new Promise((res) => setTimeout(res, delay));
+function wait(delay: number) {
+  return new Promise((res) => setTimeout(res, delay));
+}
 export async function waitForTx(txId: number, retryInterval: number = 2000) {
   let onchain = false;
   while (!onchain) {

src/utils/enc.ts renamed to src/utils/encode.ts

@@ -3,14 +3,17 @@ export const IS_BROWSER = typeof window !== 'undefined';
 
 const STRING_ZERO = '0';
 
-export const arrayBufferToString = (array: ArrayBuffer): string =>
-  String.fromCharCode.apply(null, array as unknown as number[]);
+export function arrayBufferToString(array: ArrayBuffer): string {
+  return String.fromCharCode.apply(null, array as unknown as number[]);
+}
 
-export const btoaUniversal = (b: ArrayBuffer): string =>
-  IS_BROWSER ? btoa(arrayBufferToString(b)) : Buffer.from(b).toString('base64');
+export function btoaUniversal(b: ArrayBuffer): string {
+  return IS_BROWSER ? btoa(arrayBufferToString(b)) : Buffer.from(b).toString('base64');
+}
 
-export const buf2hex = (buffer: Uint8Array) =>
-  [...buffer].map((x) => x.toString(16).padStart(2, '0')).join('');
+export function buf2hex(buffer: Uint8Array) {
+  return [...buffer].map((x) => x.toString(16).padStart(2, '0')).join('');
+}
 
 /**
  * Some function imported from https://github.com/pedrouid/enc-utils/blob/master/src/index.ts

src/utils/hash.ts

@@ -3,11 +3,13 @@ import { keccak256 } from 'ethereum-cryptography/keccak';
 import assert from 'minimalistic-assert';
 
 import { CONSTANT_POINTS, FIELD_PRIME, MASK_250, ONE, ZERO } from '../constants';
-import { ec } from '../ec';
-import { addHexPrefix, buf2hex, utf8ToArray } from './enc';
+import { ec } from '../ellipticalCurve';
+import { addHexPrefix, buf2hex, utf8ToArray } from './encode';
 import { BigNumberish, toBN } from './number';
 
-const keccakHex = (value: string): string => addHexPrefix(buf2hex(keccak256(utf8ToArray(value))));
+function keccakHex(value: string): string {
+  return addHexPrefix(buf2hex(keccak256(utf8ToArray(value))));
+}
 
 /**
  * Function to get the starknet keccak hash from a string

src/utils/index.ts

@@ -1,4 +1,4 @@
-export * as enc from './enc';
+export * as enc from './encode';
 export * as hash from './hash';
 export * as json from './json';
 export * as number from './number';

src/utils/number.ts

@@ -1,26 +1,27 @@
 import BN from 'bn.js';
 import assert from 'minimalistic-assert';
 
-import { addHexPrefix, removeHexPrefix } from './enc';
+import { addHexPrefix, removeHexPrefix } from './encode';
 
 export type BigNumberish = string | number | BN;
 
-export const isHex = (hex: string): boolean => {
+export function isHex(hex: string): boolean {
   return hex.startsWith('0x');
-};
+}
 
-export const toBN = (number: BigNumberish, base?: number | 'hex') => {
+export function toBN(number: BigNumberish, base?: number | 'hex') {
   if (typeof number === 'string' && isHex(number) && !base)
     return new BN(removeHexPrefix(number), 'hex');
   return new BN(number, base);
-};
+}
 
-export const toHex = (number: BN): string => {
+export function toHex(number: BN): string {
   return addHexPrefix(number.toString('hex'));
-};
+}
 
-export const hexToDecimalString = (hex: string): string =>
-  toBN(`0x${hex.replace(/^0x/, '')}`).toString();
+export function hexToDecimalString(hex: string): string {
+  return toBN(`0x${hex.replace(/^0x/, '')}`).toString();
+}
 
 /*
  Asserts input is equal to or greater then lowerBound and lower then upperBound.