Skip to content

Commit 5ff7a26

Browse files
committed
fix: no secrets in matrix
1 parent 1a7dc11 commit 5ff7a26

File tree

2 files changed

+16
-17
lines changed

2 files changed

+16
-17
lines changed

.github/workflows/pr.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,12 @@ jobs:
3636
TEST_PROVIDER_BASE_URL: http://127.0.0.1:5050/
3737
- name: sequencer-goerli
3838
TEST_PROVIDER_BASE_URL: https://alpha4.starknet.io
39-
TEST_ACCOUNT_PRIVATE_KEY: ${{ secrets.TEST_ACCOUNT_PRIVATE_KEY }}
40-
TEST_ACCOUNT_ADDRESS: ${{ secrets.TEST_ACCOUNT_ADDRESS }}
39+
ENABLE_TEST_ACCOUNT_PRIVATE_KEY: true
40+
ENABLE_TEST_ACCOUNT_ADDRESS: true
4141
- name: rpc-goerli
42-
TEST_RPC_URL: ${{ secrets.TEST_RPC_URL }}
43-
TEST_ACCOUNT_PRIVATE_KEY: ${{ secrets.TEST_ACCOUNT_PRIVATE_KEY }}
44-
TEST_ACCOUNT_ADDRESS: ${{ secrets.TEST_ACCOUNT_ADDRESS }}
42+
ENABLE_TEST_RPC_URL: true
43+
ENABLE_TEST_ACCOUNT_PRIVATE_KEY: true
44+
ENABLE_TEST_ACCOUNT_ADDRESS: true
4545

4646
name: Run test on ${{ matrix.name }}
4747
runs-on: ubuntu-latest
@@ -53,9 +53,9 @@ jobs:
5353
- 5050:5050
5454
env:
5555
TEST_PROVIDER_BASE_URL: ${{ matrix.TEST_PROVIDER_BASE_URL }}
56-
TEST_RPC_URL: ${{ matrix.TEST_RPC_URL }}
57-
TEST_ACCOUNT_PRIVATE_KEY: ${{ matrix.TEST_ACCOUNT_PRIVATE_KEY }}
58-
TEST_ACCOUNT_ADDRESS: ${{ matrix.TEST_ACCOUNT_ADDRESS }}
56+
TEST_RPC_URL: ${{ secrets.TEST_RPC_URL }}
57+
TEST_ACCOUNT_PRIVATE_KEY: ${{ matrix.ENABLE_TEST_ACCOUNT_PRIVATE_KEY && secrets.TEST_ACCOUNT_PRIVATE_KEY }}
58+
TEST_ACCOUNT_ADDRESS: ${{ matrix.ENABLE_TEST_ACCOUNT_ADDRESS && secrets.TEST_ACCOUNT_ADDRESS }}
5959

6060
steps:
6161
- uses: actions/checkout@v2

.github/workflows/release.yml

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -33,16 +33,15 @@ jobs:
3333
TEST_PROVIDER_BASE_URL: http://127.0.0.1:5050/
3434
- name: sequencer-goerli
3535
TEST_PROVIDER_BASE_URL: https://alpha4.starknet.io
36-
TEST_ACCOUNT_PRIVATE_KEY: ${{ secrets.TEST_ACCOUNT_PRIVATE_KEY }}
37-
TEST_ACCOUNT_ADDRESS: ${{ secrets.TEST_ACCOUNT_ADDRESS }}
36+
ENABLE_TEST_ACCOUNT_PRIVATE_KEY: true
37+
ENABLE_TEST_ACCOUNT_ADDRESS: true
3838
- name: rpc-goerli
39-
TEST_RPC_URL: ${{ secrets.TEST_RPC_URL }}
40-
TEST_ACCOUNT_PRIVATE_KEY: ${{ secrets.TEST_ACCOUNT_PRIVATE_KEY }}
41-
TEST_ACCOUNT_ADDRESS: ${{ secrets.TEST_ACCOUNT_ADDRESS }}
39+
ENABLE_TEST_RPC_URL: true
40+
ENABLE_TEST_ACCOUNT_PRIVATE_KEY: true
41+
ENABLE_TEST_ACCOUNT_ADDRESS: true
4242

4343
name: Run test on ${{ matrix.name }}
4444
runs-on: ubuntu-latest
45-
needs: ['build']
4645

4746
services:
4847
devnet:
@@ -51,9 +50,9 @@ jobs:
5150
- 5050:5050
5251
env:
5352
TEST_PROVIDER_BASE_URL: ${{ matrix.TEST_PROVIDER_BASE_URL }}
54-
TEST_RPC_URL: ${{ matrix.TEST_RPC_URL }}
55-
TEST_ACCOUNT_PRIVATE_KEY: ${{ matrix.TEST_ACCOUNT_PRIVATE_KEY }}
56-
TEST_ACCOUNT_ADDRESS: ${{ matrix.TEST_ACCOUNT_ADDRESS }}
53+
TEST_RPC_URL: ${{ secrets.TEST_RPC_URL }}
54+
TEST_ACCOUNT_PRIVATE_KEY: ${{ matrix.ENABLE_TEST_ACCOUNT_PRIVATE_KEY && secrets.TEST_ACCOUNT_PRIVATE_KEY }}
55+
TEST_ACCOUNT_ADDRESS: ${{ matrix.ENABLE_TEST_ACCOUNT_ADDRESS && secrets.TEST_ACCOUNT_ADDRESS }}
5756

5857
steps:
5958
- uses: actions/checkout@v2

0 commit comments

Comments
 (0)