Skip to content

Fix for non streaming clients #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Fix for non streaming clients #967

merged 3 commits into from
Feb 6, 2025

Conversation

dussab
Copy link
Member

@dussab dussab commented Feb 6, 2025

Fixes #799 that returned improper json for non-streaming clients. This fix also corrects ensures that the chat requests and responses are persisted properly for display in codegate admin UI.

Fixes bug that that returned improper json for non-streaming clients. This fix corrects also ensures that the chat requests and responses are persisted properly for display in codegate admin UI.
Fixes  that returned improper json for non-streaming clients. This fix corrects also ensures that the chat requests and responses are persisted properly for display in codegate admin UI.
Copy link
Contributor

@aponcedeleonch aponcedeleonch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks

@dussab dussab merged commit 91b73bf into main Feb 6, 2025
9 checks passed
@dussab dussab deleted the fix-for-non-streaming-clients branch February 6, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Receiving a null value in the content field
3 participants