This repository was archived by the owner on Jun 5, 2025. It is now read-only.
fix: remove checks for added into db because it was truncating content #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were inserting the first chunk that came from chat, and then skipping to record the subsequent requests. But the content comes in chunks, so we were not saving all the output from llm. Remove this flag, and instead execute an UPSERT to insert/update content if it was previously added
yrobla
requested review from
JAORMX,
aponcedeleonch,
jhrozek and
peppescg
and removed request for
aponcedeleonch
peppescg
approved these changes
Jan 28, 2025
aponcedeleonch
approved these changes
Jan 28, 2025
lukehinds
pushed a commit
that referenced
this pull request
Jan 31, 2025
#795) We were inserting the first chunk that came from chat, and then skipping to record the subsequent requests. But the content comes in chunks, so we were not saving all the output from llm. Remove this flag, and instead execute an UPSERT to insert/update content if it was previously added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were inserting the first chunk that came from chat, and then skipping to record the subsequent requests. But the content comes in chunks, so we were not saving all the output from llm.
Remove this flag, and instead execute an UPSERT to insert/update content if it was previously added