This repository was archived by the owner on Jun 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…get-full-workspace-config
migrations/versions/2025_03_06_1324-4b81c45b5da6_add_provider_endpoint_name_to_muxes.py
Outdated
Show resolved
Hide resolved
…get-full-workspace-config
…github.com:stacklok/codegate into endpoint-to-get-full-workspace-config
alex-mcgovern
commented
Mar 12, 2025
migrations/versions/2025_03_06_1130-769f09b6d992_add_provider_endpoint_fields_to_muxes.py
Outdated
Show resolved
Hide resolved
alex-mcgovern
commented
Mar 12, 2025
migrations/versions/2025_03_06_1130-769f09b6d992_add_provider_endpoint_fields_to_muxes.py
Outdated
Show resolved
Hide resolved
alex-mcgovern
commented
Mar 12, 2025
JAORMX
suggested changes
Mar 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The main thing is the db schema changes
migrations/versions/2025_03_06_1130-769f09b6d992_add_provider_endpoint_fields_to_muxes.py
Outdated
Show resolved
Hide resolved
JAORMX
reviewed
Mar 13, 2025
JAORMX
reviewed
Mar 13, 2025
…acklok/codegate into endpoint-to-get-full-workspace-config
…acklok/codegate into endpoint-to-get-full-workspace-config
lukehinds
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm , do we need a db migration for the changes to db/models?
There were DB schema changes in a previous iteration, but we decided they were unnecessary, the only change to a DB model is this one: class ProviderModel(BaseModel):
provider_endpoint_id: str
+ provider_endpoint_type: str
provider_endpoint_name: Optional[str] = None
name: str Which is populated via a JOIN — it's not the cleanest, but "it works"™️ |
JAORMX
approved these changes
Mar 17, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second part of #1067 — this adds a new endpoint
GET /api/v1/workspaces/:workspace_name
that returns a full workspace config.With this we have the prerequisites for a upload/download flow on a per-workspace basis.
These changes are integrated into the frontend in this PR: stacklok/codegate-ui#379
provider_endpoint_name
andprovider_endpoint_type
to themuxes
tableMuxRule
model used by the API to includeprovider_type
andprovider_name
and removesprovider_id
MuxRuleWithProviderId
model used internally for transportingmux rules
they don't require knowledge of the provider ID
GET /api/v1/workspaces/:provider_id
was already in use for listing providers in use by a workspace, but after speaking with @JAORMX we decided to move this elsewhere. You can achieve the same thing withGET /api/v1/workspaces?provider_name={ID}
now insteaddealt with in a separate PR