Skip to content

Pass fewer snippets to suspicious commands #1151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Pass fewer snippets to suspicious commands #1151

merged 1 commit into from
Feb 24, 2025

Conversation

therealnb
Copy link
Contributor

@therealnb therealnb commented Feb 21, 2025

This re-enables suspicious commands. Closes #1038

The main difference is in these lines https://github.com/stacklok/codegate/pull/1151/files#diff-0658dbd5db53af1b59ad53ac8ce9dc0ba40042abea62cce7f6b04eebf3fa4cffR56-R59

It should no longer mess with edits mode on copilot. Also, it should no longer apply if the language is any of

        "python",
        "javascript",
        "typescript",
        "go",
        "rust",
        "java",

I see the secrets warning occasionally, as per #1038, but it is not going through the suspicious commands code.

I tested this quite a lot on co-pilot, but not the other assistants. The accuracy for unfamiliar commands needs improvement.

@yrobla yrobla merged commit e3f9e9a into main Feb 24, 2025
11 checks passed
@yrobla yrobla deleted the codegate-1038 branch February 24, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suspicious commands are routing via secrets pipeline
2 participants