Skip to content

Add integration checks for comparing the result of calling the model API directly vs via CodeGate #1032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

rdimitrov
Copy link
Member

This introduces the following format:

    codegate_enrichment:
      provider_url: http://127.0.0.1:11434/api/chat
      expect_difference: false

Fixes: #841

@rdimitrov rdimitrov force-pushed the extend-tests branch 9 times, most recently from 778e682 to 2ece4d7 Compare February 13, 2025 14:43
Signed-off-by: Radoslav Dimitrov <[email protected]>
aponcedeleonch
aponcedeleonch previously approved these changes Feb 13, 2025
Copy link
Contributor

@aponcedeleonch aponcedeleonch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment. But in general the code looks good. Out of curiosity, are we not going to test also with OpenAI, Anthropic and Openrouter?

@rdimitrov
Copy link
Member Author

rdimitrov commented Feb 13, 2025

Just one comment. But in general the code looks good. Out of curiosity, are we not going to test also with OpenAI, Anthropic and Openrouter?

My understanding is that it is enough to ensure this for one provider and so it doesn't make sense to repeat it for others (and consume API tokens). Is this correct assumption or we should extend these tests for the others too?

@aponcedeleonch
Copy link
Contributor

My understanding is that it is enough to ensure this for one provider and so it doesn't make sense to repeat it for others (and consume API tokens). Is this correct assumption or we should extend these tests for the others too?

Yes, that's right

@rdimitrov rdimitrov merged commit 426105e into main Feb 13, 2025
10 checks passed
@rdimitrov rdimitrov deleted the extend-tests branch February 13, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Add integration test for comparing the result of calling the API directly vs through CodeGate
2 participants