Lint fixes

Author: joaopalet

core/auth/auth.go

@@ -1,7 +1,6 @@
 package auth
 
 import (
-	"context"
 	"encoding/json"
 	"fmt"
 	"net/http"
@@ -130,7 +129,7 @@ func TokenAuth(cfg *config.Configuration) (http.RoundTripper, error) {
 	}
 
 	client := &clients.TokenFlow{}
-	if err := client.Init(context.Background(), &tokenCfg); err != nil {
+	if err := client.Init(&tokenCfg); err != nil {
 		return nil, fmt.Errorf("error initializing client: %w", err)
 	}
 

core/clients/clients_test.go

@@ -75,7 +75,7 @@ func TestDo(t *testing.T) {
 				t.Error(err)
 				return
 			}
-			req, err := http.NewRequest(http.MethodGet, u.String(), nil)
+			req, err := http.NewRequest(http.MethodGet, u.String(), http.NoBody)
 			if err != nil {
 				t.Error(err)
 				return

core/clients/no_auth_flow_test.go

@@ -86,7 +86,7 @@ func TestNoAuthFlow_Do(t *testing.T) {
 				t.Error(err)
 				return
 			}
-			req, err := http.NewRequest(http.MethodGet, u.String(), nil)
+			req, err := http.NewRequest(http.MethodGet, u.String(), http.NoBody)
 			if err != nil {
 				t.Error(err)
 				return

core/clients/token_flow.go

@@ -1,7 +1,6 @@
 package clients
 
 import (
-	"context"
 	"fmt"
 	"net/http"
 )
@@ -33,9 +32,9 @@ func (c *TokenFlow) GetConfig() TokenFlowConfig {
 	return *c.config
 }
 
-func (c *TokenFlow) Init(ctx context.Context, cfg *TokenFlowConfig) error {
+func (c *TokenFlow) Init(cfg *TokenFlowConfig) error {
 	c.config = cfg
-	c.configureHTTPClient(ctx)
+	c.configureHTTPClient()
 	if c.config.ClientRetry == nil {
 		c.config.ClientRetry = NewRetryConfig()
 	}
@@ -54,7 +53,7 @@ func (c *TokenFlow) Clone() interface{} {
 }
 
 // configureHTTPClient configures the HTTP client
-func (c *TokenFlow) configureHTTPClient(ctx context.Context) {
+func (c *TokenFlow) configureHTTPClient() {
 	client := &http.Client{}
 	client.Timeout = DefaultClientTimeout
 	c.client = client

core/clients/token_flow_test.go

@@ -1,7 +1,6 @@
 package clients
 
 import (
-	"context"
 	"fmt"
 	"io"
 	"net/http"
@@ -14,18 +13,17 @@ import (
 
 func TestTokenFlow_Init(t *testing.T) {
 	type args struct {
-		ctx context.Context
 		cfg *TokenFlowConfig
 	}
 	tests := []struct {
 		name    string
 		args    args
 		wantErr bool
 	}{
-		{"ok", args{context.Background(), &TokenFlowConfig{
+		{"ok", args{&TokenFlowConfig{
 			ServiceAccountToken: "efg",
 		}}, false},
-		{"error 1", args{context.Background(), &TokenFlowConfig{
+		{"error 1", args{&TokenFlowConfig{
 			ServiceAccountToken: "",
 		}}, true},
 	}
@@ -38,7 +36,7 @@ func TestTokenFlow_Init(t *testing.T) {
 			if err != nil {
 				t.Fatalf("Setting service account token: %s", err)
 			}
-			if err := c.Init(tt.args.ctx, tt.args.cfg); (err != nil) != tt.wantErr {
+			if err := c.Init(tt.args.cfg); (err != nil) != tt.wantErr {
 				t.Errorf("TokenFlow.Init() error = %v, wantErr %v", err, tt.wantErr)
 			}
 			err = os.Setenv(ServiceAccountToken, b)
@@ -86,7 +84,7 @@ func TestTokenFlow_Do(t *testing.T) {
 				t.Error(err)
 				return
 			}
-			req, err := http.NewRequest(http.MethodGet, u.String(), nil)
+			req, err := http.NewRequest(http.MethodGet, u.String(), http.NoBody)
 			if err != nil {
 				t.Error(err)
 				return