feat: HBase resolvable endpoints (#1159)

* patches I

* patches I

* wip: patch hbase to use listener endpoints

* changed rendering

* rework patch for UI

* Consistently override the advertised ports

* add listener endpoint and info port to hbase-site.xml

* patch and entrypoint refactoring

* hbase: use listener service for region mover

* hbase: patch for 2.6.2 endpoints

* removed dead variable

* Update hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-port-and-use-alternative-p.patch

Co-authored-by: Natalie Klestrup Röijezon <[email protected]>

* Update hbase/stackable/patches/2.6.1/0005-Allow-overriding-ipc-bind-port-and-use-alternative-p.patch

Co-authored-by: Natalie Klestrup Röijezon <[email protected]>

* review comments: added constants etc.

* set RPC_CLIENT_SPECIFY_HOST to true by default

* corrected constant descriptions

* updated 2.6.2 patch

* patch 2.6.1 to reverse bound/advertised properties

* property re-working for 2.6.2

* provide advertised port as a fallback, removed changes to test class

---------

Co-authored-by: Natalie Klestrup Röijezon <[email protected]>

Author: adwk67

CHANGELOG.md

@@ -17,6 +17,7 @@ All notable changes to this project will be documented in this file.
   `check-permissions-ownership.sh` provided in stackable-base image ([#1029]).
 - hbase: check for correct permissions and ownerships in /stackable folder via
   `check-permissions-ownership.sh` provided in stackable-base image ([#1028]).
+- hbase: provide patches to implement listener endpoints ([#1159]).
 - hive: check for correct permissions and ownerships in /stackable folder via
   `check-permissions-ownership.sh` provided in stackable-base image ([#1040]).
 - spark-connect-client: A new image for Spark connect tests and demos ([#1034])
@@ -199,6 +200,7 @@ All notable changes to this project will be documented in this file.
 [#1151]: https://github.com/stackabletech/docker-images/pull/1151
 [#1152]: https://github.com/stackabletech/docker-images/pull/1152
 [#1156]: https://github.com/stackabletech/docker-images/pull/1156
+[#1159]: https://github.com/stackabletech/docker-images/pull/1159
 [#1163]: https://github.com/stackabletech/docker-images/pull/1163
 [#1164]: https://github.com/stackabletech/docker-images/pull/1164
 [#1165]: https://github.com/stackabletech/docker-images/pull/1165

hbase/hbase/stackable/bin/hbase-entrypoint.sh

@@ -11,15 +11,17 @@ set -euo pipefail
 
 # master, regionserver, rest
 HBASE_ROLE_NAME="$1"
-# k8s service name for this role+group combo
-# <svc-name>.<namespace>.svc.cluster.local
-HBASE_ROLE_SERVICE_NAME="$2"
 # 16010 for master, 16020 for regionservers etc.
-HBASE_ROLE_SERVICE_PORT="$3"
+HBASE_ROLE_SERVICE_PORT="$2"
+# master, regionserver, rest_http, rest_https
+HBASE_PORT_NAME="$3"
+# ui-http or ui-https
+HBASE_UI_PORT_NAME="$4"
 
-HBASE_ROLE_SERVICE_HOST="${HOSTNAME}.${HBASE_ROLE_SERVICE_NAME}"
+# Needed for regionmover service and for hbase-site.xml (see below)
+HBASE_SERVICE_HOST=$(cat /stackable/listener/default-address/address)
 
-REGION_MOVER_OPTS="--regionserverhost ${HBASE_ROLE_SERVICE_HOST}:${HBASE_ROLE_SERVICE_PORT} --operation unload ${REGION_MOVER_OPTS}"
+REGION_MOVER_OPTS="--regionserverhost ${HBASE_SERVICE_HOST}:${HBASE_ROLE_SERVICE_PORT} --operation unload ${REGION_MOVER_OPTS}"
 
 prepare_signal_handlers() {
   unset term_child_pid
@@ -64,6 +66,7 @@ cp /stackable/tmp/hdfs/core-site.xml /stackable/conf
 cp /stackable/tmp/hbase/* /stackable/conf
 cp /stackable/tmp/log_config/log4j* /stackable/conf
 
+# Kerberos
 if [ -f /stackable/kerberos/krb5.conf ]; then
   KERBEROS_REALM=$(grep -oP 'default_realm = \K.*' /stackable/kerberos/krb5.conf)
   export KERBEROS_REALM
@@ -72,6 +75,16 @@ if [ -f /stackable/kerberos/krb5.conf ]; then
   sed -i -e s/\$\{env\.KERBEROS_REALM\}/"${KERBEROS_REALM}"/g /stackable/conf/hdfs-site.xml
 fi
 
+# Service endpoints
+HBASE_SERVICE_PORT=$(cat /stackable/listener/default-address/ports/"${HBASE_PORT_NAME}")
+HBASE_INFO_PORT=$(cat /stackable/listener/default-address/ports/"${HBASE_UI_PORT_NAME}")
+HBASE_LISTENER_ENDPOINT="$HBASE_SERVICE_HOST:$HBASE_INFO_PORT"
+
+sed -i -e s/\$\{HBASE_SERVICE_HOST\}/"${HBASE_SERVICE_HOST}"/g /stackable/conf/hbase-site.xml
+sed -i -e s/\$\{HBASE_SERVICE_PORT\}/"${HBASE_SERVICE_PORT}"/g /stackable/conf/hbase-site.xml
+sed -i -e s/\$\{HBASE_LISTENER_ENDPOINT\}/"${HBASE_LISTENER_ENDPOINT}"/g /stackable/conf/hbase-site.xml
+sed -i -e s/\$\{HBASE_INFO_PORT\}/"${HBASE_INFO_PORT}"/g /stackable/conf/hbase-site.xml
+
 rm -f "${STACKABLE_LOG_DIR}/_vector/shutdown"
 prepare_signal_handlers
 /stackable/containerdebug --output="${STACKABLE_LOG_DIR}/containerdebug-state.json" --loop &