Respond to PR review

Author: jpolchlo

pystac/extensions/classification.py

@@ -17,13 +17,13 @@
 )
 
 import pystac
+import pystac.extensions.item_assets as item_assets
 from pystac.extensions.base import (
     ExtensionManagementMixin,
     PropertiesExtension,
     SummariesExtension,
 )
 from pystac.extensions.hooks import ExtensionHooks
-import pystac.extensions.item_assets as item_assets
 from pystac.extensions.raster import RasterBand
 from pystac.serialization.identify import STACJSONDescription, STACVersionID
 from pystac.utils import get_required, map_opt
@@ -86,8 +86,7 @@ def apply(
             ), "Must format color hints as '^([0-9A-F]{6})$'"
 
         if color_hint is not None:
-            color_hint_pattern = re.compile("^([0-9A-F]{6})$")
-            match = color_hint_pattern.match(color_hint)
+            match = COLOR_HINT_PATTERN.match(color_hint)
             assert (
                 color_hint is None or match is not None and match.group() == color_hint
             ), "Must format color hints as '^([0-9A-F]{6})$'"

tests/extensions/test_classification.py

@@ -1,21 +1,22 @@
-from copy import deepcopy
-from datetime import datetime
-from dateutil.parser import parse
 import json
 import logging
+from copy import deepcopy
+from datetime import datetime
 from typing import Any, Dict, List, cast
 
+import pytest
+from dateutil.parser import parse
+
 import pystac
 from pystac import Collection, Item
 from pystac.extensions.classification import (
-    Bitfield,
     CLASSES_PROP,
+    Bitfield,
     Classification,
     ClassificationExtension,
 )
 from pystac.extensions.item_assets import ItemAssetsExtension
 from pystac.extensions.raster import RasterBand, RasterExtension
-import pytest
 from tests.utils import TestCases
 
 logging.basicConfig(level=logging.DEBUG)
@@ -202,14 +203,6 @@ def test_create() -> None:
         ],
     )
 
-    assert (
-        field.__repr__() == "<Bitfield offset=8 length=2 classes=["
-        "<Classification value=0 description=No confidence level set>, "
-        "<Classification value=1 description=Low confidence cloud>, "
-        "<Classification value=2 description=Medium confidence cloud>, "
-        "<Classification value=3 description=High confidence cloud>]>"
-    )
-
     logger.info(field)