Commit 36d3ec4
authored
SEA: Allow large metadata responses (databricks#653)
* remove redundant conversion.py
Signed-off-by: varun-edachali-dbx <[email protected]>
* fix type issues
Signed-off-by: varun-edachali-dbx <[email protected]>
* ValueError not ProgrammingError
Signed-off-by: varun-edachali-dbx <[email protected]>
* reduce diff
Signed-off-by: varun-edachali-dbx <[email protected]>
* introduce SEA cloudfetch e2e tests
Signed-off-by: varun-edachali-dbx <[email protected]>
* allow empty cloudfetch result
Signed-off-by: varun-edachali-dbx <[email protected]>
* add unit tests for CloudFetchQueue and SeaResultSet
Signed-off-by: varun-edachali-dbx <[email protected]>
* skip pyarrow dependent tests
Signed-off-by: varun-edachali-dbx <[email protected]>
* simplify download process: no pre-fetching
Signed-off-by: varun-edachali-dbx <[email protected]>
* correct class name in logs
Signed-off-by: varun-edachali-dbx <[email protected]>
* align with old impl
Signed-off-by: varun-edachali-dbx <[email protected]>
* align next_n_rows with prev imple
Signed-off-by: varun-edachali-dbx <[email protected]>
* align remaining_rows with prev impl
Signed-off-by: varun-edachali-dbx <[email protected]>
* remove un-necessary Optional params
Signed-off-by: varun-edachali-dbx <[email protected]>
* remove un-necessary changes in thrift field if tests
Signed-off-by: varun-edachali-dbx <[email protected]>
* remove unused imports
Signed-off-by: varun-edachali-dbx <[email protected]>
* init hybrid
* run large queries
Signed-off-by: varun-edachali-dbx <[email protected]>
* hybrid disposition
Signed-off-by: varun-edachali-dbx <[email protected]>
* remove un-ncessary log
Signed-off-by: varun-edachali-dbx <[email protected]>
* formatting (black)
Signed-off-by: varun-edachali-dbx <[email protected]>
* remove redundant tests
Signed-off-by: varun-edachali-dbx <[email protected]>
* multi frame decompression of lz4
Signed-off-by: varun-edachali-dbx <[email protected]>
* ensure no compression (temp)
Signed-off-by: varun-edachali-dbx <[email protected]>
* introduce separate link fetcher
Signed-off-by: varun-edachali-dbx <[email protected]>
* log time to create table
Signed-off-by: varun-edachali-dbx <[email protected]>
* add chunk index to table creation time log
Signed-off-by: varun-edachali-dbx <[email protected]>
* remove custom multi-frame decompressor for lz4
Signed-off-by: varun-edachali-dbx <[email protected]>
* remove excess logs
* remove redundant tests (temp)
Signed-off-by: varun-edachali-dbx <[email protected]>
* add link to download manager before notifying consumer
Signed-off-by: varun-edachali-dbx <[email protected]>
* move link fetching immediately before table creation so link expiry is not an issue
Signed-off-by: varun-edachali-dbx <[email protected]>
* resolve merge artifacts
Signed-off-by: varun-edachali-dbx <[email protected]>
* remove redundant methods
Signed-off-by: varun-edachali-dbx <[email protected]>
* formatting (black)
Signed-off-by: varun-edachali-dbx <[email protected]>
* introduce callback to handle link expiry
Signed-off-by: varun-edachali-dbx <[email protected]>
* fix types
Signed-off-by: varun-edachali-dbx <[email protected]>
* fix param type in unit tests
Signed-off-by: varun-edachali-dbx <[email protected]>
* formatting + minor type fixes
Signed-off-by: varun-edachali-dbx <[email protected]>
* Revert "introduce callback to handle link expiry"
This reverts commit bd51b1c.
* remove unused callback (to be introduced later)
Signed-off-by: varun-edachali-dbx <[email protected]>
* correct param extraction
Signed-off-by: varun-edachali-dbx <[email protected]>
* remove common constructor for databricks client abc
Signed-off-by: varun-edachali-dbx <[email protected]>
* make SEA Http Client instance a private member
Signed-off-by: varun-edachali-dbx <[email protected]>
* make GetChunksResponse model more robust
Signed-off-by: varun-edachali-dbx <[email protected]>
* add link to doc of GetChunk response model
Signed-off-by: varun-edachali-dbx <[email protected]>
* pass result_data instead of "initial links" into SeaCloudFetchQueue
Signed-off-by: varun-edachali-dbx <[email protected]>
* move download_manager init into parent CloudFetchQueue
Signed-off-by: varun-edachali-dbx <[email protected]>
* raise ServerOperationError for no 0th chunk
Signed-off-by: varun-edachali-dbx <[email protected]>
* unused iports
Signed-off-by: varun-edachali-dbx <[email protected]>
* return None in case of empty respose
Signed-off-by: varun-edachali-dbx <[email protected]>
* ensure table is empty on no initial link s
Signed-off-by: varun-edachali-dbx <[email protected]>
* account for total chunk count
Signed-off-by: varun-edachali-dbx <[email protected]>
* iterate by chunk index instead of link
Signed-off-by: varun-edachali-dbx <[email protected]>
* make LinkFetcher convert link static
Signed-off-by: varun-edachali-dbx <[email protected]>
* add helper for link addition, check for edge case to prevent inf wait
Signed-off-by: varun-edachali-dbx <[email protected]>
* add unit tests for LinkFetcher
Signed-off-by: varun-edachali-dbx <[email protected]>
* remove un-necessary download manager check
Signed-off-by: varun-edachali-dbx <[email protected]>
* remove un-necessary string literals around param type
Signed-off-by: varun-edachali-dbx <[email protected]>
* remove duplicate download_manager init
Signed-off-by: varun-edachali-dbx <[email protected]>
* account for empty response in LinkFetcher init
Signed-off-by: varun-edachali-dbx <[email protected]>
* make get_chunk_link return mandatory ExternalLink
Signed-off-by: varun-edachali-dbx <[email protected]>
* set shutdown_event instead of breaking on completion so get_chunk_link is informed
Signed-off-by: varun-edachali-dbx <[email protected]>
* docstrings, logging, pydoc
Signed-off-by: varun-edachali-dbx <[email protected]>
* use total_chunk_cound > 0
Signed-off-by: varun-edachali-dbx <[email protected]>
* clarify that link has already been submitted on getting row_offset
Signed-off-by: varun-edachali-dbx <[email protected]>
* return None for out of range
Signed-off-by: varun-edachali-dbx <[email protected]>
* default link_fetcher to None
Signed-off-by: varun-edachali-dbx <[email protected]>
---------
Signed-off-by: varun-edachali-dbx <[email protected]>
* Chunk download latency (databricks#634)
* chunk download latency
Signed-off-by: Sai Shree Pradhan <[email protected]>
* formatting
Signed-off-by: Sai Shree Pradhan <[email protected]>
* test fixes
Signed-off-by: Sai Shree Pradhan <[email protected]>
* sea-migration static type checking fixes
Signed-off-by: Sai Shree Pradhan <[email protected]>
* check types fix
Signed-off-by: Sai Shree Pradhan <[email protected]>
* fix type issues
Signed-off-by: varun-edachali-dbx <[email protected]>
* type fix revert
Signed-off-by: Sai Shree Pradhan <[email protected]>
* -
Signed-off-by: Sai Shree Pradhan <[email protected]>
* statement id in get metadata functions
Signed-off-by: Sai Shree Pradhan <[email protected]>
* removed result set extractor
Signed-off-by: Sai Shree Pradhan <[email protected]>
* databricks client type
Signed-off-by: Sai Shree Pradhan <[email protected]>
* formatting
Signed-off-by: Sai Shree Pradhan <[email protected]>
* remove defaults, fix chunk id
Signed-off-by: Sai Shree Pradhan <[email protected]>
* added statement type to command id
Signed-off-by: Sai Shree Pradhan <[email protected]>
* check types fix
Signed-off-by: Sai Shree Pradhan <[email protected]>
* renamed chunk_id to num_downloaded_chunks
Signed-off-by: Sai Shree Pradhan <[email protected]>
* set statement type to query for chunk download
Signed-off-by: Sai Shree Pradhan <[email protected]>
* comment fix
Signed-off-by: Sai Shree Pradhan <[email protected]>
* removed dup check for trowset
Signed-off-by: Sai Shree Pradhan <[email protected]>
---------
Signed-off-by: Sai Shree Pradhan <[email protected]>
* acquire lock before notif + formatting (black)
Signed-off-by: varun-edachali-dbx <[email protected]>
* fix imports
Signed-off-by: varun-edachali-dbx <[email protected]>
* add get_chunk_link s
Signed-off-by: varun-edachali-dbx <[email protected]>
* simplify description extraction
Signed-off-by: varun-edachali-dbx <[email protected]>
* pass session_id_hex to ThriftResultSet
Signed-off-by: varun-edachali-dbx <[email protected]>
* revert to main's extract description
Signed-off-by: varun-edachali-dbx <[email protected]>
* validate row count for sync query tests as well
Signed-off-by: varun-edachali-dbx <[email protected]>
* guid_hex -> hex_guid
Signed-off-by: varun-edachali-dbx <[email protected]>
* reduce diff
Signed-off-by: varun-edachali-dbx <[email protected]>
* reduce diff
Signed-off-by: varun-edachali-dbx <[email protected]>
* reduce diff
Signed-off-by: varun-edachali-dbx <[email protected]>
* set .value in compression
Signed-off-by: varun-edachali-dbx <[email protected]>
* reduce diff
Signed-off-by: varun-edachali-dbx <[email protected]>
* is_direct_results -> has_more_rows
Signed-off-by: varun-edachali-dbx <[email protected]>
* preliminary large metadata results
Signed-off-by: varun-edachali-dbx <[email protected]>
* account for empty table in arrow table filter
Signed-off-by: varun-edachali-dbx <[email protected]>
* align flows
Signed-off-by: varun-edachali-dbx <[email protected]>
* align flow of json with arrow
Signed-off-by: varun-edachali-dbx <[email protected]>
* case sensitive support for arrow table
Signed-off-by: varun-edachali-dbx <[email protected]>
* remove un-necessary comment
Signed-off-by: varun-edachali-dbx <[email protected]>
* fix merge artifacts
Signed-off-by: varun-edachali-dbx <[email protected]>
* remove redundant method
Signed-off-by: varun-edachali-dbx <[email protected]>
* remove incorrect docstring
Signed-off-by: varun-edachali-dbx <[email protected]>
* remove deepcopy
Signed-off-by: varun-edachali-dbx <[email protected]>
---------
Signed-off-by: varun-edachali-dbx <[email protected]>1 parent 3b0c882 commit 36d3ec4
File tree
4 files changed
+314
-89
lines changed- src/databricks/sql/backend/sea
- utils
- tests/unit
4 files changed
+314
-89
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
158 | 158 | | |
159 | 159 | | |
160 | 160 | | |
| 161 | + | |
161 | 162 | | |
162 | 163 | | |
163 | 164 | | |
| |||
694 | 695 | | |
695 | 696 | | |
696 | 697 | | |
697 | | - | |
| 698 | + | |
698 | 699 | | |
699 | 700 | | |
700 | 701 | | |
| |||
727 | 728 | | |
728 | 729 | | |
729 | 730 | | |
730 | | - | |
| 731 | + | |
731 | 732 | | |
732 | 733 | | |
733 | 734 | | |
| |||
768 | 769 | | |
769 | 770 | | |
770 | 771 | | |
771 | | - | |
| 772 | + | |
772 | 773 | | |
773 | 774 | | |
774 | 775 | | |
| |||
815 | 816 | | |
816 | 817 | | |
817 | 818 | | |
818 | | - | |
| 819 | + | |
819 | 820 | | |
820 | 821 | | |
821 | 822 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| 9 | + | |
9 | 10 | | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
13 | 14 | | |
14 | | - | |
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
23 | 33 | | |
24 | 34 | | |
25 | 35 | | |
| |||
30 | 40 | | |
31 | 41 | | |
32 | 42 | | |
33 | | - | |
34 | | - | |
35 | | - | |
| 43 | + | |
36 | 44 | | |
37 | | - | |
| 45 | + | |
38 | 46 | | |
39 | 47 | | |
40 | | - | |
41 | | - | |
| 48 | + | |
42 | 49 | | |
43 | 50 | | |
44 | | - | |
| 51 | + | |
45 | 52 | | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
| 53 | + | |
| 54 | + | |
59 | 55 | | |
60 | 56 | | |
61 | 57 | | |
| |||
64 | 60 | | |
65 | 61 | | |
66 | 62 | | |
67 | | - | |
68 | | - | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
69 | 71 | | |
70 | | - | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
71 | 78 | | |
72 | | - | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
73 | 96 | | |
74 | 97 | | |
75 | | - | |
76 | | - | |
77 | | - | |
| 98 | + | |
| 99 | + | |
78 | 100 | | |
79 | | - | |
| 101 | + | |
80 | 102 | | |
81 | 103 | | |
82 | 104 | | |
83 | 105 | | |
84 | | - | |
| 106 | + | |
85 | 107 | | |
86 | 108 | | |
87 | 109 | | |
88 | 110 | | |
89 | | - | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
90 | 199 | | |
91 | 200 | | |
92 | | - | |
| 201 | + | |
93 | 202 | | |
94 | 203 | | |
95 | 204 | | |
| |||
107 | 216 | | |
108 | 217 | | |
109 | 218 | | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
110 | 222 | | |
111 | | - | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
112 | 227 | | |
113 | 228 | | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
| 236 | + | |
| 237 | + | |
| 238 | + | |
| 239 | + | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
114 | 245 | | |
115 | | - | |
116 | | - | |
117 | | - | |
118 | | - | |
119 | | - | |
120 | | - | |
121 | | - | |
122 | | - | |
123 | | - | |
124 | | - | |
125 | | - | |
| 246 | + | |
| 247 | + | |
126 | 248 | | |
127 | 249 | | |
128 | 250 | | |
| |||
143 | 265 | | |
144 | 266 | | |
145 | 267 | | |
146 | | - | |
147 | 268 | | |
148 | 269 | | |
149 | | - | |
150 | | - | |
151 | | - | |
| 270 | + | |
152 | 271 | | |
| 272 | + | |
153 | 273 | | |
154 | | - | |
155 | | - | |
156 | | - | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
0 commit comments