This repository was archived by the owner on Sep 11, 2020. It is now read-only.
Implement git log --all #1044
Closed
Implement git log --all #1044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kuba-- <[email protected]>
kuba--
commented
Jan 3, 2019
| l := list.New() | ||
| m := make(map[plumbing.Hash]*list.Element) | ||
|
|
||
| commitIter.ForEach(func(c *Commit) error { |
There was a problem hiding this comment.
Maybe we don't need to populate a list by commitIter which is the first iterator (in other words for --all we may ignore From option and just go through all references)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kuba-- [email protected]
This PR implements
git log --all.It closes #1024
It's also related to #1023
Please take a look carefully if it can be done in more optimal way.