Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

Ref names aren't validated leading to interesting behavior #1172

Open
@thecjharries

Description

@thecjharries

While I was learning this library this weekend, I noticed there's no validation on ref names. I cooked up a quick demo to show how to take advantage of that behavior. It's not a huge deal given that most people probably aren't trying to screw with their branch names.

https://github.com/thecjharries/go-git-ref-bug

I also looked at fixing the problem. Unfortunately, the root cause, a simple string for ReferenceName, is too embedded everywhere to change with my very limited knowledge of Go. I'm about to submit a PR with a rough draft of a solution that I'll probably be using myself elsewhere.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions